Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support tls for tiflash #3049

Merged
merged 5 commits into from
Aug 4, 2020
Merged

support tls for tiflash #3049

merged 5 commits into from
Aug 4, 2020

Conversation

DanielZhangQD
Copy link
Contributor

What problem does this PR solve?

Fix #3027

What is changed and how does it work?

Support TLS for TiFlash

Check List

Tests

  • Unit test
  • E2E test
  • Manual test (add detailed scripts or steps below)
    • Deploy TiDB Cluster with TiFlash with TLS enabled
    • Deploy TiDB Cluster with TiFlash with TLS disabled

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Support TLS for TiFlash

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2020 •
edited
Loading

Codecov Report

Merging #3049 into master will increase coverage by 0.18%.
The diff coverage is 67.07%.

@@            Coverage Diff             @@
##           master    #3049      +/-   ##
==========================================
+ Coverage   42.16%   42.35%   +0.18%     
==========================================
  Files         156      156              
  Lines       16709    16756      +47     
==========================================
+ Hits         7046     7097      +51     
+ Misses       9092     9086       -6     
- Partials      571      573       +2
Flag Coverage Δ
#unittest 42.35% <67.07%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@DanielZhangQD
Copy link
Contributor Author

Since TLS is only supported with nightly version of TiFlash now, the e2e will be done in #3053 later.

lichunzhu
lichunzhu approved these changes Aug 4, 2020
View reviewed changes
Copy link
Contributor

@lichunzhu lichunzhu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD DanielZhangQD merged commit 114b189 into pingcap:master Aug 4, 2020
@DanielZhangQD DanielZhangQD deleted the flash0 branch August 4, 2020 09:47
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Aug 4, 2020
@DanielZhangQD @ti-srebot
cherry pick pingcap#3049 to release-1.1
a395b72 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 4, 2020
Merged
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #3066

DanielZhangQD added a commit that referenced this pull request Aug 4, 2020
@ti-srebot @DanielZhangQD
cherry pick #3049 to release-1.1 (#3066)
3ddafba 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: DanielZhangQD <36026334+DanielZhangQD@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofyc cofyc cofyc approved these changes

@lichunzhu lichunzhu lichunzhu approved these changes

@ti-srebot ti-srebot ti-srebot approved these changes

@weekface weekface Awaiting requested review from weekface

Assignees
No one assigned
Labels
needs-cherry-pick-1.1 status/LGT2
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support TLS for TiFlash
5 participants
@DanielZhangQD @codecov-commenter @ti-srebot @cofyc @lichunzhu