Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update logic of orphan pod cleaner (#3107) #3112

Merged
merged 2 commits into from
Aug 14, 2020

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3107 to release-1.1


What problem does this PR solve?

Fix some logic error in the orphan pod cleaner introduced in #2709

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test

Code changes

  • Has Go code change

Related changes

  • Need to cherry-pick to the release branch

Does this PR introduce a user-facing change?:

NONE

Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2020

Codecov Report

❗ No coverage uploaded for pull request base (release-1.1@9d37e46). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-1.1    #3112   +/-   ##
==============================================
  Coverage               ?   44.64%           
==============================================
  Files                  ?      148           
  Lines                  ?    15794           
  Branches               ?        0           
==============================================
  Hits                   ?     7051           
  Misses                 ?     8177           
  Partials               ?      566           
Flag Coverage Δ
#unittest 44.64% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@ti-srebot
Copy link
Contributor Author

/run-all-tests

@ti-srebot ti-srebot merged commit 2008f08 into pingcap:release-1.1 Aug 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants