Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Patch PVCs when storage request is increased (#3096) #3122

Closed
wants to merge 3 commits into from
Closed

Patch PVCs when storage request is increased (#3096) #3122

wants to merge 3 commits into from

Conversation

ti-srebot
Copy link
Contributor

cherry-pick #3096 to release-1.1

What problem does this PR solve?

fixes #3004

What is changed and how does it work?

Check List

Tests

  • Unit test
  • E2E test
  • Stability test
  • Manual test (add detailed scripts or steps below)
  • No code

Code changes

  • Has Go code change
  • Has CI related scripts change
  • Has Terraform scripts change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Support patching PVCs when the storage request is increased. Due to the limitation of the current statefulset, new PVCs will be created with the old storage request and resized later

@cofyc @ti-srebot
cherry pick pingcap#3096 to release-1.1
09a01ef 
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot ti-srebot mentioned this pull request Aug 18, 2020
Merged
@ti-srebot ti-srebot added this to the v1.1.4 milestone Aug 18, 2020
@cofyc cofyc closed this Aug 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cofyc cofyc cofyc left review comments

@DanielZhangQD DanielZhangQD Awaiting requested review from DanielZhangQD

@lichunzhu lichunzhu Awaiting requested review from lichunzhu

@weekface weekface Awaiting requested review from weekface

Assignees

@cofyc cofyc

Labels
None yet
Projects
None yet
Milestone
v1.1.4
Development

Successfully merging this pull request may close these issues.
2 participants
@ti-srebot @cofyc