Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump operator to v1.1.8 and tidb components to v4.0.9 #3613

Merged
merged 6 commits into from
Dec 21, 2020

Conversation

dragonly
Copy link
Contributor

@dragonly dragonly commented Dec 17, 2020

What problem does this PR solve?

Bump operator to v1.1.8 and tidb components to v4.0.9

What is changed and how does it work?

ref #3490
run script hack/bump-version.sh, and correct some comments by hand.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

NONE

@dragonly
Copy link
Contributor Author

The CI cannot build, because tidb v4.0.9 has not been released yet. Just wait...

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@handlerww handlerww left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-io
Copy link

codecov-io commented Dec 19, 2020

Codecov Report

Merging #3613 (f999b57) into master (929f1c7) will increase coverage by 0.17%.
The diff coverage is 86.98%.

@@            Coverage Diff             @@
##           master    #3613      +/-   ##
==========================================
+ Coverage   62.44%   62.62%   +0.17%     
==========================================
  Files         164      164              
  Lines       17195    17293      +98     
==========================================
+ Hits        10737    10829      +92     
+ Misses       5425     5424       -1     
- Partials     1033     1040       +7     
Flag Coverage Δ
unittest 62.62% <86.98%> (?)

@dragonly
Copy link
Contributor Author

/run-test-e2e

@DanielZhangQD
Copy link
Contributor

/run-all-tests

@DanielZhangQD
Copy link
Contributor

/run-all-tests

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind-serial

1 similar comment
@dragonly
Copy link
Contributor Author

/test pull-e2e-kind-serial

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind

@DanielZhangQD DanielZhangQD merged commit c8539ac into pingcap:master Dec 21, 2020
ti-srebot pushed a commit to ti-srebot/tidb-operator that referenced this pull request Dec 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>
@ti-srebot
Copy link
Contributor

cherry pick to release-1.1 in PR #3632

DanielZhangQD pushed a commit that referenced this pull request Dec 21, 2020
Signed-off-by: ti-srebot <ti-srebot@pingcap.com>

Co-authored-by: Yilong Li <liyilongko@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants