Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump operator version to v1.2.0-beta.1 #3898

Merged
merged 3 commits into from
Apr 7, 2021

Conversation

handlerww
Copy link
Contributor

@handlerww handlerww commented Apr 7, 2021

What problem does this PR solve?

Bump operator to v1.2.0-beta.1

What is changed and how does it work?

ref #3897
run script hack/bump-version.sh to bump TiDB Operator from v1.2.0-alpha.1 to v1.2.0-beta.1

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

NONE

@handlerww handlerww changed the title Bump operator version to v1.2.0-alpha.1 Bump operator version to v1.2.0-beta.1 Apr 7, 2021
@codecov-io
Copy link

codecov-io commented Apr 7, 2021

Codecov Report

Merging #3898 (03f4f20) into master (2286554) will decrease coverage by 5.39%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #3898      +/-   ##
==========================================
- Coverage   67.82%   62.42%   -5.40%     
==========================================
  Files         175      171       -4     
  Lines       18619    18134     -485     
==========================================
- Hits        12629    11321    -1308     
- Misses       4887     5716     +829     
+ Partials     1103     1097       -6     
Flag Coverage Δ
e2e ?
unittest 62.42% <ø> (ø)

@csuzhangxc
Copy link
Member

you need to update the PR description. 😹

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@handlerww
Copy link
Contributor Author

/run-all-tests

@handlerww
Copy link
Contributor Author

you need to update the PR description. 😹

Yeah, I forgot it. 😹

@handlerww
Copy link
Contributor Author

/cc @july2993 @liubog2008

Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • DanielZhangQD
  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by writing /lgtm in a comment.
Reviewer can cancel approval by writing /lgtm cancel in a comment.

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: f91e4ef

@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind

1 similar comment
@DanielZhangQD
Copy link
Contributor

/test pull-e2e-kind

@ti-chi-bot
Copy link
Member

@handlerww: Your PR was out of date, I have automatically updated it for you.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the ti-community-infra/tichi repository.

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot ti-chi-bot merged commit c56f717 into pingcap:master Apr 7, 2021
@handlerww handlerww deleted the bump_1.2.0-beta.1 branch June 12, 2021 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants