Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump operator to v1.1.13 and tidb components to v4.0.13 #4056

Merged
merged 4 commits into from
Jul 2, 2021

Conversation

KanShiori
Copy link
Collaborator

What problem does this PR solve?

Bump operator to v1.1.13 and tidb components to v4.0.13

What is changed and how does it work?

ref #3920

run script hack/bump-version.sh, and correct some comments by hand.

Code changes

  • Has Go code change
  • Has CI related scripts change

Tests

  • Unit test
  • E2E test
  • Manual test
  • No code

Side effects

  • Breaking backward compatibility
  • Other side effects:

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Release Notes

Please refer to Release Notes Language Style Guide before writing the release note.

None

Copy link
Member

@csuzhangxc csuzhangxc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ti-chi-bot
Copy link
Member

[REVIEW NOTIFICATION]

This pull request has been approved by:

  • csuzhangxc

To complete the pull request process, please ask the reviewers in the list to review by filling /cc @reviewer in the comment.
After your PR has acquired the required number of LGTMs, you can assign this pull request to the committer in the list by filling /assign @committer in the comment to help you merge this pull request.

The full list of commands accepted by this bot can be found here.

Reviewer can indicate their review by submitting an approval review.
Reviewer can cancel approval by submitting a request changes review.

@codecov-commenter
Copy link

codecov-commenter commented Jul 2, 2021

Codecov Report

❗ No coverage uploaded for pull request base (release-1.1@6f4b099). Click here to learn what that means.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             release-1.1    #4056   +/-   ##
==============================================
  Coverage               ?   52.56%           
==============================================
  Files                  ?      161           
  Lines                  ?    15633           
  Branches               ?        0           
==============================================
  Hits                   ?     8217           
  Misses                 ?     6632           
  Partials               ?      784           
Flag Coverage Δ
unittest 52.56% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@KanShiori KanShiori mentioned this pull request Jul 2, 2021
8 tasks
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@DanielZhangQD
Copy link
Contributor

/merge

@ti-chi-bot
Copy link
Member

This pull request has been accepted and is ready to merge.

Commit hash: cf07ec4

@csuzhangxc csuzhangxc merged commit 79ad44b into pingcap:release-1.1 Jul 2, 2021
@KanShiori KanShiori deleted the bump-version-1.1.13 branch July 5, 2021 03:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants