Add a new RequeueError type #80
Conversation
|
/run-e2e-tests |
|
It looks like this removes aggregate error creation because they will not pass the test |
|
I have the function |
|
This sounds good. We should be waiting for that feature. |
weekface
changed the title
weekface
changed the title
|
Switched to |
weekface
force-pushed
the
requeue-error
branch
from
5e6891c
to
8b0fd5b
Compare
weekface
force-pushed
the
requeue-error
branch
from
8b0fd5b
to
18ce1fe
Compare
| @@ -216,7 +217,13 @@ func (tcc *Controller) processNextWorkItem() bool { | |||
| } | |||
| defer tcc.queue.Done(key) | |||
| if err := tcc.sync(key.(string)); err != nil { | |||
| utilruntime.HandleError(fmt.Errorf("Error syncing TidbCluster %v, requeuing: %v", key.(string), err)) | |||
| if reqErr := pingcaperrors.Find(err, func(e error) bool { | |||
There was a problem hiding this comment.
I think you can just do pingcaperrors.Find(err, controller.IsRequeueError)
|
I am asking over on pingcap/tidb#7151 about importing pingcap/errors as pkg/errors since we are maintaining backwards compatibility. |
|
We are maintaining backwards compatibility for pingcap/errors with pkg/errors, so it is better to import pingcap/errors as pkg/errors as done in TiDB |
|
/run-e2e-tests |
|
/run-e2e-tests |
* add RequeueError * make lint happy * use pingcap/errors.Find
This PR resolves #50 .
@tennix @onlymellb @xiaojingchen @gregwebs PTAL