Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support configuring resources requests and limits for all containers of tidb cluster #853

Merged
merged 5 commits into from
Aug 30, 2019
Merged

Support configuring resources requests and limits for all containers of tidb cluster #853

merged 5 commits into from
Aug 30, 2019

Conversation

aylei
Copy link
Contributor

@aylei aylei commented Aug 30, 2019

close #852
Signed-off-by: Aylei rayingecho@gmail.com

What problem does this PR solve?

What is changed and how does it work?

Check List

Tests

  • E2E test

Code changes

  • Has Helm charts change
  • Has Go code change
  • Has CI related scripts change
  • Has documents change

Side effects

  • Breaking backward compatibility

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

Support configuring resources requests and limits for all containers of tidb cluster

@aylei
Support confiugring resources requests and limits for all containers …
ce7797d 
…of tidb cluster

Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei
Copy link
Contributor Author

aylei commented Aug 30, 2019

@weekface @tennix @qiffang PTAL

@aylei
Copy link
Contributor Author

aylei commented Aug 30, 2019

/run-e2e-tests

@aylei
Copy link
Contributor Author

aylei commented Aug 30, 2019

/run-e2e-in-kind

@aylei
Align values.yaml
4200c1d 
Signed-off-by: Aylei <rayingecho@gmail.com>
@aylei
Merge upstream
23faa61
tennix
tennix approved these changes Aug 30, 2019
View reviewed changes
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor Author

aylei commented Aug 30, 2019

/run-e2e-in-kind

DanielZhangQD
DanielZhangQD approved these changes Aug 30, 2019
View reviewed changes
Copy link
Contributor

@DanielZhangQD DanielZhangQD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tennix tennix merged commit 8f81b48 into pingcap:master Aug 30, 2019
@sre-bot
Copy link
Contributor

sre-bot commented Aug 30, 2019

cherry pick to release-1.0 failed

@aylei aylei mentioned this pull request Nov 7, 2019
Merged
tennix pushed a commit that referenced this pull request Nov 8, 2019
@aylei @tennix
Cherry pick of #853: configure resources for all containers (#1119)
f8a0379 
* Support confiugring resources requests and limits for all containers of tidb cluster

Signed-off-by: Aylei <rayingecho@gmail.com>

* Update values.yaml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weekface weekface weekface approved these changes

@tennix tennix tennix approved these changes

@DanielZhangQD DanielZhangQD DanielZhangQD approved these changes

@qiffang qiffang Awaiting requested review from qiffang

Assignees
No one assigned
Labels
needs-cherry-pick-1.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The resources of all the containers should be configurable
5 participants
@aylei @sre-bot @weekface @tennix @DanielZhangQD