Monitoring: enable alert rules persistence #898
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tennix
reviewed
Sep 10, 2019
| @@ -121,6 +125,8 @@ spec: | |||
| imagePullPolicy: {{ .Values.monitor.reloader.imagePullPolicy | default "IfNotPresent" }} | |||
| command: | |||
| - /bin/reload | |||
| - --root-store-path=/data | |||
| - --sub-store-path={{ .Values.tidb.image }} | |||
There was a problem hiding this comment.
This command-line argument looks odd, can we rename it to make the name and value match?
There was a problem hiding this comment.
reloader 想做成和 TIDB 没什么关联独立存在的 prometheus ui reload 工具，所以取了和 TIDB 无关的名字
There was a problem hiding this comment.
Yes, this is OK. But maybe we can convert the .Values.tidb.image to the expected path in Helm template.
tennix
changed the title
weekface
previously approved these changes
Oct 11, 2019
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
|
/run-e2e-in-kind |
|
cherry pick to release-1.0 failed |
qiffang
added a commit
to qiffang/tidb-operator
that referenced
this pull request
Dec 23, 2019
…upstream-release-1.0
yahonda
pushed a commit
that referenced
this pull request
Dec 27, 2021
* update tkctl debug usage * Update en/use-tkctl.md * Update en/use-tkctl.md Co-authored-by: Ran <huangran@pingcap.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Previously, The new alert rules added by monitoring-reloader will be loss if prometheus restart.
It is unreasonable and we update the logic following rules
TiDB Version is not changed, the updated rules should be persistence even though prometheus restart
TiDB Version is changed, the updated rules will be loss (It is also stored PV).
The Cluster is deleted, the updated rules will be loss (It is also stored PV).
It is related the PR
What is changed and how does it work?
Check List
Tests
Upgrade TIDB Cluster but do not change the TIDB version , the updated files will be persisted
Upgrade TIDB Version, Updated rules is loss
Code changes
Does this PR introduce a user-facing change?: