Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix values file customization for tidb-operator on aliyun #971

Merged
merged 2 commits into from
Oct 9, 2019

Conversation

DanielZhangQD
Copy link
Contributor

What problem does this PR solve?

fix #970

What is changed and how does it work?

Support values file customization for tidb-operator

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    tidb-operator can be customized with specific values.yaml

Code changes

  • Has terraform scripts change
  • Has documents change

Related changes

  • Need to cherry-pick to the release branch
  • Need to update the documentation

Does this PR introduce a user-facing change?:

fix values file customization for tidb-operator on aliyun

@DanielZhangQD DanielZhangQD added the type/bug Something isn't working label Sep 30, 2019
Copy link
Member

@tennix tennix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@aylei aylei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aylei
Copy link
Contributor

aylei commented Oct 9, 2019

/run-e2e-in-kind

@DanielZhangQD
Copy link
Contributor Author

/run-e2e-in-kind

@sre-bot
Copy link
Contributor

sre-bot commented Oct 9, 2019

cherry pick to release-1.0 in PR #983

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-cherry-pick-1.0 type/bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cannot customize tidb-operator with values file on aliyun
4 participants