pkg: refine tls && update tidb version #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
kennytm
reviewed
Mar 12, 2020
|
@kennytm @csuzhangxc PTAL |
kennytm
reviewed
Mar 12, 2020
Comment on lines
+136
to
+138
| // client2 can't visit server | ||
| _, err = ClientWithTLS(clientTLS2).Get(url) | ||
| c.Assert(err, ErrorMatches, ".*tls: bad certificate") |
There was a problem hiding this comment.
will the server accept client2 if the common name is localhost (the CA's common name)?
There was a problem hiding this comment.
no, you will see the log of unit test:
2020/03/12 12:21:44 http: TLS handshake error from 127.0.0.1:51864: client certificate authentication failed. The Common Name from the client certificate [client2 localhost] was not found in the configuration cluster-verify-cn with value: [client1]
the common name already include localhost
52 tasks
july2993
approved these changes
Mar 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
What is changed and how it works?
Check List
Tests