-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
9 changed files
with
111 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,12 @@ | ||
| load("@io_bazel_rules_go//go:def.bzl", "go_library") | ||
|
|
||
| go_library( | ||
| name = "gofmt", | ||
| srcs = ["analyzer.go"], | ||
| importpath = "github.com/pingcap/tidb/build/linter/gofmt", | ||
| visibility = ["//visibility:public"], | ||
| deps = [ | ||
| "@com_github_golangci_gofmt//gofmt", | ||
| "@org_golang_x_tools//go/analysis", | ||
| ], | ||
| ) |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,65 @@ | ||
| // Copyright 2022 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package gofmt | ||
|
|
||
| import ( | ||
| "fmt" | ||
| "strings" | ||
|
|
||
| "github.com/golangci/gofmt/gofmt" | ||
| "golang.org/x/tools/go/analysis" | ||
| ) | ||
|
|
||
| // Analyzer is the analyzer struct of gofmt. | ||
| var Analyzer = &analysis.Analyzer{ | ||
| Name: "gofmt", | ||
| Doc: "gofmt checks whether code was gofmt-ed" + | ||
| "this tool runs with -s option to check for code simplification", | ||
| Run: run, | ||
| } | ||
|
|
||
| var needSimplify bool | ||
|
|
||
| func init() { | ||
| Analyzer.Flags.BoolVar(&needSimplify, "need-simplify", true, "run gofmt with -s for code simplification") | ||
| } | ||
|
|
||
| func run(pass *analysis.Pass) (any, error) { | ||
| fileNames := make([]string, 0, 10) | ||
| for _, f := range pass.Files { | ||
| pos := pass.Fset.PositionFor(f.Pos(), false) | ||
| if pos.Filename != "" && !strings.HasSuffix(pos.Filename, "failpoint_binding__.go") { | ||
| fileNames = append(fileNames, pos.Filename) | ||
| } | ||
| } | ||
|
|
||
| for _, f := range fileNames { | ||
| diff, err := gofmt.Run(f, needSimplify) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("could not run gofmt: %w (%s)", err, f) | ||
| } | ||
|
|
||
| if diff == nil { | ||
| continue | ||
| } | ||
|
|
||
| pass.Report(analysis.Diagnostic{ | ||
| Pos: 1, | ||
| Message: fmt.Sprintf("\n%s", diff), | ||
| }) | ||
| } | ||
|
|
||
| return nil, nil | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters