*: use bytes.Equal to check byte slice equivalent (#11706) (#16174)

pingcap · Apr 13, 2020 · 3f6a2b9 · 3f6a2b9
1 parent fc1d679
commit 3f6a2b9
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 3 deletions.
diff --git a/executor/analyze.go b/executor/analyze.go
@@ -686,7 +686,7 @@ func (e *AnalyzeFastExec) getNextSampleKey(bo *tikv.Backoffer, startKey kv.Key)
 		if err != nil {
 			return nil, err
 		}
-		if bytes.Compare(loc.StartKey, e.sampTasks[prefixLen].Location.EndKey) == 0 {
+		if bytes.Equal(loc.StartKey, e.sampTasks[prefixLen].Location.EndKey) {
 			startKey = loc.StartKey
 			break
 		}

diff --git a/executor/load_data.go b/executor/load_data.go
@@ -14,6 +14,7 @@
 package executor
 
 import (
+	"bytes"
 	"context"
 	"fmt"
 	"strings"
@@ -30,6 +31,10 @@ import (
 	"go.uber.org/zap"
 )
 
+var (
+	null = []byte("NULL")
+)
+
 // LoadDataExec represents a load data executor.
 type LoadDataExec struct {
 	baseExecutor
@@ -486,7 +491,7 @@ func (e *LoadDataInfo) getFieldsFromLine(line []byte) ([]field, error) {
 	for {
 		eol, f := reader.GetField()
 		f = f.escape()
-		if string(f.str) == "NULL" && !f.enclosed {
+		if bytes.Equal(f.str, null) && !f.enclosed {
 			f.str = []byte{'N'}
 			f.maybeNull = true
 		}

diff --git a/store/tikv/region_cache.go b/store/tikv/region_cache.go
@@ -636,7 +636,7 @@ func (c *RegionCache) loadRegion(bo *Backoffer, key []byte, isEndKey bool) (*Reg
 		if len(meta.Peers) == 0 {
 			return nil, errors.New("receive Region with no peer")
 		}
-		if isEndKey && !searchPrev && bytes.Compare(meta.StartKey, key) == 0 && len(meta.StartKey) != 0 {
+		if isEndKey && !searchPrev && bytes.Equal(meta.StartKey, key) && len(meta.StartKey) != 0 {
 			searchPrev = true
 			continue
 		}