test

Signed-off-by: wjhuang2016 <huangwenjun1997@gmail.com>

util/ranger/detacher.go

@@ -533,7 +533,8 @@ func ExtractEqAndInCondition(sctx sessionctx.Context, conditions []expression.Ex
 			mergedAccesses[offset] = accesses[offset]
 			points[offset] = rb.build(accesses[offset])
 		}
-		points[offset] = rb.intersection(points[offset], rb.build(cond))
+		_, col := cond.CharsetAndCollation()
+		points[offset] = rb.intersection(points[offset], rb.build(cond), collate.GetCollator(col))
 		if len(points[offset]) == 0 { // Early termination if false expression found
 			if expression.MaybeOverOptimized4PlanCache(sctx, conditions) {
 				// cannot return an empty-range for plan-cache since the range may become non-empty as parameters change

util/ranger/points.go

@@ -83,9 +83,10 @@ func (rp *point) Clone(value types.Datum) *point {
 }
 
 type pointSorter struct {
-	points []*point
-	err    error
-	sc     *stmtctx.StatementContext
+	points   []*point
+	err      error
+	sc       *stmtctx.StatementContext
+	collator collate.Collator
 }
 
 func (r *pointSorter) Len() int {
@@ -95,18 +96,18 @@ func (r *pointSorter) Len() int {
 func (r *pointSorter) Less(i, j int) bool {
 	a := r.points[i]
 	b := r.points[j]
-	less, err := rangePointLess(r.sc, a, b)
+	less, err := rangePointLess(r.sc, a, b, r.collator)
 	if err != nil {
 		r.err = err
 	}
 	return less
 }
 
-func rangePointLess(sc *stmtctx.StatementContext, a, b *point) (bool, error) {
+func rangePointLess(sc *stmtctx.StatementContext, a, b *point, collator collate.Collator) (bool, error) {
 	if a.value.Kind() == types.KindMysqlEnum && b.value.Kind() == types.KindMysqlEnum {
 		return rangePointEnumLess(sc, a, b)
 	}
-	cmp, err := a.value.CompareDatum(sc, &b.value)
+	cmp, err := a.value.Compare(sc, &b.value, collator)
 	if cmp != 0 {
 		return cmp < 0, nil
 	}
@@ -567,9 +568,6 @@ func (r *builder) buildFromIn(expr *expression.ScalarFunction) ([]*point, bool)
 			hasNull = true
 			continue
 		}
-		if dt.Kind() == types.KindString || dt.Kind() == types.KindBinaryLiteral {
-			dt.SetString(dt.GetString(), colCollate)
-		}
 		if expr.GetArgs()[0].GetType().Tp == mysql.TypeEnum {
 			switch dt.Kind() {
 			case types.KindString, types.KindBytes, types.KindBinaryLiteral:
@@ -604,7 +602,7 @@ func (r *builder) buildFromIn(expr *expression.ScalarFunction) ([]*point, bool)
 		endPoint := &point{value: endValue}
 		rangePoints = append(rangePoints, startPoint, endPoint)
 	}
-	sorter := pointSorter{points: rangePoints, sc: r.sc}
+	sorter := pointSorter{points: rangePoints, sc: r.sc, collator: collate.GetCollator(colCollate)}
 	sort.Sort(&sorter)
 	if sorter.err != nil {
 		r.err = sorter.err
@@ -765,13 +763,15 @@ func (r *builder) buildFromNot(expr *expression.ScalarFunction) []*point {
 }
 
 func (r *builder) buildFromScalarFunc(expr *expression.ScalarFunction) []*point {
+	_, coll := expr.CharsetAndCollation()
+	collator := collate.GetCollator(coll)
 	switch op := expr.FuncName.L; op {
 	case ast.GE, ast.GT, ast.LT, ast.LE, ast.EQ, ast.NE, ast.NullEQ:
 		return r.buildFromBinOp(expr)
 	case ast.LogicAnd:
-		return r.intersection(r.build(expr.GetArgs()[0]), r.build(expr.GetArgs()[1]))
+		return r.intersection(r.build(expr.GetArgs()[0]), r.build(expr.GetArgs()[1]), collator)
 	case ast.LogicOr:
-		return r.union(r.build(expr.GetArgs()[0]), r.build(expr.GetArgs()[1]))
+		return r.union(r.build(expr.GetArgs()[0]), r.build(expr.GetArgs()[1]), collator)
 	case ast.IsTruthWithoutNull:
 		return r.buildFromIsTrue(expr, 0, false)
 	case ast.IsTruthWithNull:
@@ -794,19 +794,19 @@ func (r *builder) buildFromScalarFunc(expr *expression.ScalarFunction) []*point
 	return nil
 }
 
-func (r *builder) intersection(a, b []*point) []*point {
-	return r.merge(a, b, false)
+func (r *builder) intersection(a, b []*point, collator collate.Collator) []*point {
+	return r.merge(a, b, false, collator)
 }
 
-func (r *builder) union(a, b []*point) []*point {
-	return r.merge(a, b, true)
+func (r *builder) union(a, b []*point, collator collate.Collator) []*point {
+	return r.merge(a, b, true, collator)
 }
 
-func (r *builder) mergeSorted(a, b []*point) []*point {
+func (r *builder) mergeSorted(a, b []*point, collator collate.Collator) []*point {
 	ret := make([]*point, 0, len(a)+len(b))
 	i, j := 0, 0
 	for i < len(a) && j < len(b) {
-		less, err := rangePointLess(r.sc, a[i], b[j])
+		less, err := rangePointLess(r.sc, a[i], b[j], collator)
 		if err != nil {
 			r.err = err
 			return nil
@@ -827,8 +827,8 @@ func (r *builder) mergeSorted(a, b []*point) []*point {
 	return ret
 }
 
-func (r *builder) merge(a, b []*point, union bool) []*point {
-	mergedPoints := r.mergeSorted(a, b)
+func (r *builder) merge(a, b []*point, union bool, collator collate.Collator) []*point {
+	mergedPoints := r.mergeSorted(a, b, collator)
 	if r.err != nil {
 		return nil
 	}

util/ranger/ranger.go

@@ -296,7 +296,7 @@ func buildColumnRange(accessConditions []expression.Expression, sctx sessionctx.
 	rb := builder{sc: sctx.GetSessionVars().StmtCtx}
 	rangePoints := getFullRange()
 	for _, cond := range accessConditions {
-		rangePoints = rb.intersection(rangePoints, rb.build(cond))
+		rangePoints = rb.intersection(rangePoints, rb.build(cond), collate.GetCollator(tp.Collate))
 		if rb.err != nil {
 			return nil, errors.Trace(rb.err)
 		}
@@ -372,7 +372,7 @@ func (d *rangeDetacher) buildCNFIndexRange(newTp []*types.FieldType,
 	rangePoints := getFullRange()
 	// Build rangePoints for non-equal access conditions.
 	for i := eqAndInCount; i < len(accessCondition); i++ {
-		rangePoints = rb.intersection(rangePoints, rb.build(accessCondition[i]))
+		rangePoints = rb.intersection(rangePoints, rb.build(accessCondition[i]), collate.GetCollator(newTp[eqAndInCount].Collate))
 		if rb.err != nil {
 			return nil, errors.Trace(rb.err)
 		}