Skip to content

Commit

Permalink
test: fix an unit test that is too strict (#46677)
Browse files Browse the repository at this point in the history
close #46678
  • Loading branch information
lance6716 authored Sep 5, 2023
1 parent 9adc183 commit 923d98f
Showing 1 changed file with 14 additions and 14 deletions.
28 changes: 14 additions & 14 deletions br/pkg/lightning/backend/external/split_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -69,20 +69,20 @@ notExhausted:
lenStatFiles := len(statFiles)
require.Equal(t, lenDataFiles, lenStatFiles)
require.Greater(t, lenDataFiles, 0)
require.Greater(t, len(splitKeys), 0)

// splitKeys should be strictly increasing
for i := 1; i < len(splitKeys); i++ {
cmp := bytes.Compare(splitKeys[i], splitKeys[i-1])
require.Equal(t, 1, cmp, "splitKeys: %v", splitKeys)
}
// first splitKeys should be strictly greater than lastEndKey
cmp := bytes.Compare(splitKeys[0], lastEndKey)
require.Equal(t, 1, cmp, "splitKeys: %v, lastEndKey: %v", splitKeys, lastEndKey)
// last splitKeys should be strictly less than endKey
if endKey != nil {
cmp = bytes.Compare(splitKeys[len(splitKeys)-1], endKey)
require.Equal(t, -1, cmp, "splitKeys: %v, endKey: %v", splitKeys, endKey)
if len(splitKeys) > 0 {
// splitKeys should be strictly increasing
for i := 1; i < len(splitKeys); i++ {
cmp := bytes.Compare(splitKeys[i], splitKeys[i-1])
require.Equal(t, 1, cmp, "splitKeys: %v", splitKeys)
}
// first splitKeys should be strictly greater than lastEndKey
cmp := bytes.Compare(splitKeys[0], lastEndKey)
require.Equal(t, 1, cmp, "splitKeys: %v, lastEndKey: %v", splitKeys, lastEndKey)
// last splitKeys should be strictly less than endKey
if endKey != nil {
cmp = bytes.Compare(splitKeys[len(splitKeys)-1], endKey)
require.Equal(t, -1, cmp, "splitKeys: %v, endKey: %v", splitKeys, endKey)
}
}

lastEndKey = endKey
Expand Down

0 comments on commit 923d98f

Please sign in to comment.