-
Notifications
You must be signed in to change notification settings - Fork 5.8k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
util: create the tmpdir if the directory is removed by mistake. (#18970…
…) (#19272) * cherry pick #18970 to release-4.0 Signed-off-by: ti-srebot <ti-srebot@pingcap.com> * fix cherry-pick * remove useless line Co-authored-by: Shenghui Wu <793703860@qq.com>
- Loading branch information
Showing
7 changed files
with
199 additions
and
54 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,110 @@ | ||
| // Copyright 2020 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package disk | ||
|
|
||
| import ( | ||
| "io/ioutil" | ||
| "os" | ||
| "path/filepath" | ||
|
|
||
| "github.com/danjacques/gofslock/fslock" | ||
| "github.com/pingcap/errors" | ||
| "github.com/pingcap/log" | ||
| "github.com/pingcap/parser/terror" | ||
| "github.com/pingcap/tidb/config" | ||
| "go.uber.org/zap" | ||
| "golang.org/x/sync/singleflight" | ||
| ) | ||
|
|
||
| var ( | ||
| tempDirLock fslock.Handle | ||
| sf singleflight.Group | ||
| ) | ||
|
|
||
| // CheckAndInitTempDir check whether the temp directory is existed. | ||
| // If not, initializes the temp directory. | ||
| func CheckAndInitTempDir() (err error) { | ||
| _, err, _ = sf.Do("tempDir", func() (value interface{}, err error) { | ||
| if !checkTempDirExist() { | ||
| log.Info("Tmp-storage-path not found. Try to initialize TempDir.") | ||
| err = InitializeTempDir() | ||
| } | ||
| return | ||
| }) | ||
| return | ||
| } | ||
|
|
||
| func checkTempDirExist() bool { | ||
| tempDir := config.GetGlobalConfig().TempStoragePath | ||
| _, err := os.Stat(tempDir) | ||
| if err != nil && !os.IsExist(err) { | ||
| return false | ||
| } | ||
| return true | ||
| } | ||
|
|
||
| // InitializeTempDir initializes the temp directory. | ||
| func InitializeTempDir() error { | ||
| tempDir := config.GetGlobalConfig().TempStoragePath | ||
| _, err := os.Stat(tempDir) | ||
| if err != nil && !os.IsExist(err) { | ||
| err = os.MkdirAll(tempDir, 0755) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } | ||
| lockFile := "_dir.lock" | ||
| tempDirLock, err = fslock.Lock(filepath.Join(tempDir, lockFile)) | ||
| if err != nil { | ||
| switch err { | ||
| case fslock.ErrLockHeld: | ||
| log.Error("The current temporary storage dir has been occupied by another instance, "+ | ||
| "check tmp-storage-path config and make sure they are different.", zap.String("TempStoragePath", tempDir), zap.Error(err)) | ||
| default: | ||
| log.Error("Failed to acquire exclusive lock on the temporary storage dir.", zap.String("TempStoragePath", tempDir), zap.Error(err)) | ||
| } | ||
| return err | ||
| } | ||
|
|
||
| subDirs, err := ioutil.ReadDir(tempDir) | ||
| if err != nil { | ||
| return err | ||
| } | ||
|
|
||
| // If it exists others files except lock file, creates another goroutine to clean them. | ||
| if len(subDirs) > 1 { | ||
| go func() { | ||
| for _, subDir := range subDirs { | ||
| // Do not remove the lock file. | ||
| if subDir.Name() == lockFile { | ||
| continue | ||
| } | ||
| err := os.RemoveAll(filepath.Join(tempDir, subDir.Name())) | ||
| if err != nil { | ||
| log.Warn("Remove temporary file error", | ||
| zap.String("tempStorageSubDir", filepath.Join(tempDir, subDir.Name())), zap.Error(err)) | ||
| } | ||
| } | ||
| }() | ||
| } | ||
| return nil | ||
| } | ||
|
|
||
| // CleanUp releases the directory lock when exiting TiDB. | ||
| func CleanUp() { | ||
| if tempDirLock != nil { | ||
| err := tempDirLock.Unlock() | ||
| terror.Log(errors.Trace(err)) | ||
| } | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| // Copyright 2020 PingCAP, Inc. | ||
| // | ||
| // Licensed under the Apache License, Version 2.0 (the "License"); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an "AS IS" BASIS, | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package disk | ||
|
|
||
| import ( | ||
| "os" | ||
| "sync" | ||
| "testing" | ||
|
|
||
| "github.com/pingcap/check" | ||
| "github.com/pingcap/tidb/config" | ||
| ) | ||
|
|
||
| func TestT(t *testing.T) { | ||
| check.TestingT(t) | ||
| } | ||
|
|
||
| var _ = check.SerialSuites(&testDiskSerialSuite{}) | ||
|
|
||
| type testDiskSerialSuite struct { | ||
| } | ||
|
|
||
| func (s *testDiskSerialSuite) TestRemoveDir(c *check.C) { | ||
| err := InitializeTempDir() | ||
| c.Assert(err, check.IsNil) | ||
| c.Assert(checkTempDirExist(), check.Equals, true) | ||
| c.Assert(os.RemoveAll(config.GetGlobalConfig().TempStoragePath), check.IsNil) | ||
| c.Assert(checkTempDirExist(), check.Equals, false) | ||
| wg := sync.WaitGroup{} | ||
| for i := 0; i < 10; i++ { | ||
| wg.Add(1) | ||
| go func(c *check.C) { | ||
| err := CheckAndInitTempDir() | ||
| c.Assert(err, check.IsNil) | ||
| wg.Done() | ||
| }(c) | ||
| } | ||
| wg.Wait() | ||
| err = CheckAndInitTempDir() | ||
| c.Assert(err, check.IsNil) | ||
| c.Assert(checkTempDirExist(), check.Equals, true) | ||
| } |