Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let PointGet be a choice of DataSource's PhysicalPlan. #14044

Closed
winoros opened this issue Dec 12, 2019 · 1 comment · Fixed by #14775
Closed

Let PointGet be a choice of DataSource's PhysicalPlan. #14044

winoros opened this issue Dec 12, 2019 · 1 comment · Fixed by #14775
Assignees
@lzmhhh123
Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution sig/planner SIG: Planner type/performance

Comments

@winoros
Copy link
Member

winoros commented Dec 12, 2019

Feature Request

There're two api to access data in TiKV. One is kv's Get/BatchGet, the other is coprocessor. Get/BatchGet is lighter than coprocessor. There's no other calculation(like filter or aggregate). The Get will have significant stronger performance compared with coprocessor.

So there is a need to make the PointGet as a choice of DataSource's Physical Plan.
@winoros winoros mentioned this issue Dec 17, 2019
Closed
@winoros winoros added the help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. label Dec 17, 2019
@winoros winoros mentioned this issue Feb 3, 2020
Open
@zz-jason
Copy link
Member

zz-jason commented Feb 5, 2020

The Get will have significant stronger performance compared with coprocessor.

Do we have some benchmark result to quantify the performance difference?

@lzmhhh123 lzmhhh123 self-assigned this Feb 6, 2020
@lzmhhh123 lzmhhh123 mentioned this issue Feb 13, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lzmhhh123 lzmhhh123

Labels
help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. sig/execution SIG execution sig/planner SIG: Planner type/performance
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

planner, executor: support point get as a option of DataSource lzmhhh123/tidb
3 participants
@zz-jason @winoros @lzmhhh123