planner, executor: support point get as a option of DataSource
#14775
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lzmhhh123
added
status/WIP
sig/planner
ghost
requested review from
eurekaka and
winoros
and removed request for
a team
ghost
requested review from
SunRunAway and
XuHuaiyu
and removed request for
a team
coocood
reviewed
Mar 6, 2020
planner/core/find_best_task.go
Outdated
| rTsk.p = sel | ||
| } | ||
| } else { | ||
| if !candidate.path.Index.Unique || |
There was a problem hiding this comment.
Can we check this before allRangesIsPoint, so we don't need to do the wasted computation?
coocood
reviewed
Mar 6, 2020
planner/core/find_best_task.go
Outdated
| prop.TaskTp == property.CopSingleReadTaskType && !candidate.isSingleScan { | ||
| return invalidTask, nil | ||
| } | ||
| if candidate.path.StoreType == kv.TiFlash { |
There was a problem hiding this comment.
Can we do all the checks before allRangeIsPoint? then this function doesn't need to return error.
|
LGTM |
lzmhhh123
added
the
status/can-merge
|
/run-all-tests |
|
@lzmhhh123 merge failed. |
|
/run-all-test |
|
/run-all-tests |
coocood
approved these changes
Mar 9, 2020
|
/merge |
|
Your auto merge job has been accepted, waiting for 15114 |
|
/run-all-tests |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
As the title says.
fix #14044
Check List
Tests
Code changes