Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide & deprecate enable-streaming #20759

Closed
SunRunAway opened this issue Nov 2, 2020 · 7 comments · Fixed by #20760
Closed

hide & deprecate enable-streaming #20759

SunRunAway opened this issue Nov 2, 2020 · 7 comments · Fixed by #20760
Labels
sig/execution SIG execution

Comments

@SunRunAway
Copy link
Contributor

SunRunAway commented Nov 2, 2020

Feature Request

Is your feature request related to a problem? Please describe:

enable-streaming is not well maintained because we are focusing on optimizing the non-streaming coprocessor API for its performance and resource usage and don’t have time to optimize streaming's currently, I propose to deprecate it temporarily until somebody has time to pick it up again and prove it could be GA in the future.

Describe the feature you'd like:

Describe alternatives you've considered:

Teachability, Documentation, Adoption, Migration Strategy:

see https://asktug.com/t/topic/37526/7

@SunRunAway SunRunAway added the type/feature-request Categorizes issue or PR as related to a new feature. label Nov 2, 2020
@SunRunAway
Copy link
Contributor Author

/cc @zz-jason @breeswish

@zz-jason
Copy link
Member

zz-jason commented Nov 2, 2020

@SunRunAway could you link all the bugs that related to streaming API? Without seeing this bug list, it's hard to decide whether to deprecate it temporarily.

@zz-jason zz-jason added priority/awaiting-more-evidence and removed type/feature-request Categorizes issue or PR as related to a new feature. labels Nov 2, 2020
@SunRunAway
Copy link
Contributor Author

@SunRunAway
Copy link
Contributor Author

We are currently focusing on optimizing the non-streaming coprocessor API for its performance and resource usage, but when the users enable the steaming API, they will not be benefited from us.

@breezewish
Copy link
Member

breezewish commented Nov 2, 2020

@zz-jason There are a lot of known trivial issues, for example,

  1. TiKV known bug: Selection executor does not handle start_scan or stop_scan correctly tikv/tikv#3677 (won't fix)
  2. TiKV does not handle streaming scan efficiently
  3. Coprocessor Cache does not work in streaming
  4. The runtime statistics in streaming mode is not correct. The newly added ScanDetailV2 may be incorrect as well.
  5. When I reviewed the Coprocessor part in TiDB I found that it may not correctly handle the case that partial result is lost and request is retried. There is no test case for this either.

In summary, the streaming API seems to be not complete and not efficient. There is no plan to optimize. Tests may not completely covered as well.

@zz-jason
Copy link
Member

zz-jason commented Nov 2, 2020

@breeswish got it, thanks.

@breezewish
Copy link
Member

Some other related issues:

#31928
#13293

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/execution SIG execution
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants