-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
copr: fix lockerr when streaming #31934
Conversation
Signed-off-by: you06 <you1474600@gmail.com>
[REVIEW NOTIFICATION] This pull request has been approved by:
To complete the pull request process, please ask the reviewers in the list to review by filling The full list of commands accepted by this bot can be found here. Reviewer can indicate their review by submitting an approval review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Seems it's not easy to write unit tests for it.
The fix seems to be ok but streaming is deprecated #20759 |
Yeah, so the priority is low. But fixing it won't be a bad thing. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
Signed-off-by: you06 you1474600@gmail.com
What problem does this PR solve?
Issue Number: close #31928
Problem Summary:
What is changed and how it works?
Because coprocessor request will return
nil
range field when meeting lock,calculateRetry
is no more required, and the current usage can lead to duplicated range scan. This PR removecalculateRetry
and usecalculateRemain
instead.Check List
Tests
Side effects
Documentation
Release note