Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

potential wrong flag when setting default value #35846

Closed
wjhuang2016 opened this issue Jun 30, 2022 · 0 comments · Fixed by #35845
Closed

potential wrong flag when setting default value #35846

wjhuang2016 opened this issue Jun 30, 2022 · 0 comments · Fixed by #35845
Labels
severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@wjhuang2016
Copy link
Member

wjhuang2016 commented Jun 30, 2022

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

create table txx(a YEAR NULL DEFAULT '2029');

DDL1: alter table txx modify column a MEDIUMINT NULL DEFAULT '-8145111';
DDL2: alter table txx alter a SET DEFAULT '2098';

Send DDL1 and DD2 to TiDB concurrently, and DDL1 runs first.

The show create table should be

mediumint(9) DEFAULT '2098',

not

mediumint(9) unsigned zerofill DEFAULT '2098'

The flag of column a is wrong after setting the default value.

4. What is your TiDB version? (Required)

master

@wjhuang2016 wjhuang2016 added type/bug The issue is confirmed as a bug. severity/moderate labels Jun 30, 2022
@wjhuang2016 wjhuang2016 added the sig/sql-infra SIG: SQL Infra label Jun 30, 2022
you06 added a commit to you06/tidb that referenced this issue Jul 1, 2022
Signed-off-by: you06 <you1474600@gmail.com>

fix tests

Signed-off-by: you06 <you1474600@gmail.com>

fix test

Signed-off-by: you06 <you1474600@gmail.com>

update

Signed-off-by: you06 <you1474600@gmail.com>

update bazel

Signed-off-by: you06 <you1474600@gmail.com>

fix test

Signed-off-by: you06 <you1474600@gmail.com>

fix test

Signed-off-by: you06 <you1474600@gmail.com>

update

Signed-off-by: you06 <you1474600@gmail.com>

update client-go

Signed-off-by: you06 <you1474600@gmail.com>

update client-go

Signed-off-by: you06 <you1474600@gmail.com>

update grafana

Signed-off-by: you06 <you1474600@gmail.com>

update bazel

Signed-off-by: you06 <you1474600@gmail.com>

display by stack

Signed-off-by: you06 <you1474600@gmail.com>

set request source for ctx of

Signed-off-by: you06 <you1474600@gmail.com>

address comment

Signed-off-by: you06 <you1474600@gmail.com>

address comment

Signed-off-by: you06 <you1474600@gmail.com>

parser, ddl: support decoding binary literal in set/enum (pingcap#35822)

close pingcap#31338

executor: fix a nil point when @@tidb_enable_collect_execution_info is off and cop cache is on (pingcap#35839)

close pingcap#35829

ddl: support drop columns for multi-schema change (pingcap#35737)

ref pingcap#14766

planner: don't push down predicates over table dual (pingcap#35669)

close pingcap#35527

*: Remove some useless staleness code (pingcap#35849)

close pingcap#35848

ddl: fix potential wrong column definition when setting default value (pingcap#35845)

close pingcap#35846

*: add timeout for test cases (pingcap#35844)

ddl: remove `onDropColumns` and `onAddColumns` (pingcap#35862)

ref pingcap#14766

*: Fix Dockerfile (pingcap#35835)

close pingcap#35828

server: refactor TestConnExecutionTimeout (pingcap#35865)

close pingcap#35868

fix test

Signed-off-by: you06 <you1474600@gmail.com>

fix lint

Signed-off-by: you06 <you1474600@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
severity/moderate sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant