DATA RACE in the stmtsummary

[hawkingrei]

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

==================

WARNING: DATA RACE

Write at 0x00c004f12e70 by goroutine 116:

  runtime.mapassign_faststr()

      GOROOT/src/runtime/map_faststr.go:203 +0x0

  github.com/pingcap/tidb/util/stmtsummary.(*stmtSummaryByDigestElement).add()

      util/stmtsummary/statement_summary.go:665 +0x166

  github.com/pingcap/tidb/util/stmtsummary.(*stmtSummaryByDigest).add()

      util/stmtsummary/statement_summary.go:573 +0xb2

  github.com/pingcap/tidb/util/stmtsummary.(*stmtSummaryByDigestMap).AddStatement()

      util/stmtsummary/statement_summary.go:340 +0x590

  github.com/pingcap/tidb/executor.(*ExecStmt).SummaryStmt()

      executor/adapter.go:1790 +0x1bf1

  github.com/pingcap/tidb/executor.(*ExecStmt).FinishExecuteStmt()

      executor/adapter.go:1364 +0x7de

  github.com/pingcap/tidb/executor.(*ExecStmt).CloseRecordSet()

      executor/adapter.go:1394 +0x64

  github.com/pingcap/tidb/executor.(*recordSet).Close()

      executor/adapter.go:183 +0xcb

  github.com/pingcap/tidb/session.(*execStmtResult).Close()

      session/session.go:2377 +0x7e

  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()

      testkit/testkit.go:132 +0x28f

  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()

      testkit/testkit.go:122 +0xf7

  github.com/pingcap/tidb/bindinfo_test.TestCaptureUserFilter()

      bindinfo/capture_test.go:643 +0xb5a

  github.com/pingcap/tidb/session.runStmt()

      session/session.go:2322 +0x85c

  github.com/pingcap/tidb/session.(*session).ExecuteStmt()

      session/session.go:2186 +0x1266

  github.com/pingcap/tidb/testkit.(*TestKit).ExecWithContext()

      testkit/testkit.go:295 +0x84e

  github.com/pingcap/tidb/testkit.(*TestKit).MustExecWithContext()

      testkit/testkit.go:127 +0xb7

  github.com/pingcap/tidb/testkit.(*TestKit).MustExec()

      testkit/testkit.go:122 +0xf7

  github.com/pingcap/tidb/bindinfo_test.TestCaptureUserFilter()

      bindinfo/capture_test.go:611 +0xd0

  github.com/pingcap/tidb/domain.(*Domain).rebuildSysVarCache()

      domain/sysvar_cache.go:146 +0x73c

  github.com/pingcap/tidb/domain.(*Domain).LoadSysVarCacheLoop()

      domain/domain.go:1319 +0xb9

  github.com/pingcap/tidb/session.BootstrapSession()

      session/session.go:2919 +0x74c

  github.com/pingcap/tidb/domain.(*Domain).GetSessionCache()

      domain/sysvar_cache.go:62 +0x6a

  github.com/pingcap/tidb/session.(*session).loadCommonGlobalVariablesIfNeeded()

      session/session.go:3168 +0x11e

  github.com/pingcap/tidb/session.(*session).ExecuteStmt()

      session/session.go:2101 +0x2fb

  github.com/pingcap/tidb/session.(*session).ExecuteInternal()

      session/session.go:1664 +0x4eb

  github.com/pingcap/tidb/domain.(*Domain).LoadPrivilegeLoop()

      domain/domain.go:1261 +0x143

  github.com/pingcap/tidb/session.BootstrapSession()

      session/session.go:2912 +0x6ec

  github.com/pingcap/tidb/testkit.bootstrap()

      testkit/mockstore.go:83 +0xa4

  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()

      testkit/mockstore.go:69 +0xd0

  github.com/pingcap/tidb/bindinfo_test.TestCaptureUserFilter()

      bindinfo/capture_test.go:607 +0x58

  testing.tRunner()

      GOROOT/src/testing/testing.go:1446 +0x216

  testing.(*T).Run.func1()

      GOROOT/src/testing/testing.go:1493 +0x47


Previous read at 0x00c004f12e70 by goroutine 14242:

  runtime.mapiternext()

      GOROOT/src/runtime/map.go:866 +0x0

  github.com/pingcap/tidb/bindinfo.(*BindHandle).CaptureBaselines()

      bindinfo/handle.go:876 +0xfd3

  github.com/pingcap/tidb/domain.(*Domain).globalBindHandleWorkerLoop.func1()

      domain/domain.go:1436 +0x519


Goroutine 116 (running) created at:

  testing.(*T).Run()

      GOROOT/src/testing/testing.go:1493 +0x75d

  testing.runTests.func1()

      GOROOT/src/testing/testing.go:1846 +0x99

  testing.tRunner()

      GOROOT/src/testing/testing.go:1446 +0x216

  testing.runTests()

      GOROOT/src/testing/testing.go:1844 +0x7ec

  testing.(*M).Run()

      GOROOT/src/testing/testing.go:1726 +0xa84

  go.uber.org/goleak.VerifyTestMain()

      external/org_uber_go_goleak/testmain.go:53 +0x70

  github.com/pingcap/tidb/bindinfo_test.TestMain()

      bindinfo/main_test.go:32 +0x43c

  main.main()

      bazel-out/k8-fastbuild/bin/bindinfo/bindinfo_test_/testmain.go:268 +0x7c9


Goroutine 14242 (running) created at:

  github.com/pingcap/tidb/domain.(*Domain).globalBindHandleWorkerLoop()

      domain/domain.go:1410 +0x10a

  github.com/pingcap/tidb/domain.(*Domain).LoadBindInfoLoop()

      domain/domain.go:1403 +0x1f5

  github.com/pingcap/tidb/session.BootstrapSession()

      session/session.go:2906 +0x648

  github.com/pingcap/tidb/testkit.bootstrap()

      testkit/mockstore.go:83 +0xa4

  github.com/pingcap/tidb/testkit.CreateMockStoreAndDomain()

      testkit/mockstore.go:69 +0xd0

  github.com/pingcap/tidb/bindinfo_test.TestCaptureUserFilter()

      bindinfo/capture_test.go:607 +0x58

  testing.tRunner()

      GOROOT/src/testing/testing.go:1446 +0x216

  testing.(*T).Run.func1()

      GOROOT/src/testing/testing.go:1493 +0x47

==================

2. What did you expect to see? (Required)

3. What did you see instead (Required)

4. What is your TiDB version? (Required)