Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

data race when building executor #41412

Closed
Tracked by #41316
you06 opened this issue Feb 14, 2023 · 0 comments · Fixed by #41413
Closed
Tracked by #41316

data race when building executor #41412

you06 opened this issue Feb 14, 2023 · 0 comments · Fixed by #41413
Labels
affects-6.6 severity/major type/bug The issue is confirmed as a bug.

Comments

@you06
Copy link
Contributor

you06 commented Feb 14, 2023 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Fghpr_mysql_test/detail/ghpr_mysql_test/15018/pipeline/

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

No race detected.

3. What did you see instead (Required)

WARNING: DATA RACE

Write at 0x00c0388895d9 by goroutine 867628:
  github.com/pingcap/tidb/executor.(*dataReaderBuilder).buildIndexLookUpReaderForIndexJoin()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/builder.go:4472 +0x11d
  github.com/pingcap/tidb/executor.(*dataReaderBuilder).buildExecutorForIndexJoinInternal()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/builder.go:4114 +0xa84
  github.com/pingcap/tidb/executor.(*dataReaderBuilder).buildExecutorForIndexJoin()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/builder.go:4103 +0x328
  github.com/pingcap/tidb/executor.(*innerWorker).fetchInnerResults()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/index_lookup_join.go:690 +0x128
  github.com/pingcap/tidb/executor.(*innerWorker).handleTask()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/index_lookup_join.go:528 +0x1a4
  github.com/pingcap/tidb/executor.(*innerWorker).run()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/index_lookup_join.go:502 +0x1be
  github.com/pingcap/tidb/executor.(*IndexLookUpJoin).startWorkers.func2()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/index_lookup_join.go:193 +0x64

Previous write at 0x00c0388895d9 by goroutine 867631:
  github.com/pingcap/tidb/executor.(*dataReaderBuilder).buildIndexLookUpReaderForIndexJoin()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/builder.go:4472 +0x11d
  github.com/pingcap/tidb/executor.(*dataReaderBuilder).buildExecutorForIndexJoinInternal()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/builder.go:4114 +0xa84
  github.com/pingcap/tidb/executor.(*dataReaderBuilder).buildExecutorForIndexJoin()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/builder.go:4103 +0x328
  github.com/pingcap/tidb/executor.(*innerWorker).fetchInnerResults()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/index_lookup_join.go:690 +0x128
  github.com/pingcap/tidb/executor.(*innerWorker).handleTask()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/index_lookup_join.go:528 +0x1a4
  github.com/pingcap/tidb/executor.(*innerWorker).run()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/index_lookup_join.go:502 +0x1be
  github.com/pingcap/tidb/executor.(*IndexLookUpJoin).startWorkers.func2()
      /home/jenkins/agent/workspace/pingcap/tidb/ghpr_mysql_test/tidb/executor/index_lookup_join.go:193 +0x64

4. What is your TiDB version? (Required)

0b6ccdc
@you06 you06 added the type/bug The issue is confirmed as a bug. label Feb 14, 2023
@you06 you06 mentioned this issue Feb 14, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 may-affects-6.4 may-affects-6.5 may-affects-6.6 labels Feb 15, 2023
@you06 you06 removed severity/major may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 may-affects-6.4 may-affects-6.5 may-affects-6.6 labels Feb 15, 2023
@you06 you06 added affects-6.6 and removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 may-affects-6.4 may-affects-6.5 may-affects-6.6 labels Feb 15, 2023
@hawkingrei hawkingrei mentioned this issue Feb 15, 2023
Open
blacktear23 pushed a commit to blacktear23/tidb that referenced this issue Feb 15, 2023
@you06 @blacktear23
executor: fix race when collecting telemetry info of batch copr (ping…
1626677 
…cap#41413)

close pingcap#41412
ghazalfamilyusa pushed a commit to ghazalfamilyusa/tidb that referenced this issue Feb 15, 2023
@you06 @ghazalfamilyusa
executor: fix race when collecting telemetry info of batch copr (ping…
663478d 
…cap#41413)

close pingcap#41412
@cfzjywxk cfzjywxk mentioned this issue Mar 23, 2023
Merged
15 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-6.6 severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: fix race when collecting telemetry info of batch copr you06/tidb
3 participants
@you06 @tangenta @ti-chi-bot