Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

goleak in the gctuner.(*memoryLimitTuner).tuning #41524

Closed
Tracked by #41316
hawkingrei opened this issue Feb 16, 2023 · 0 comments · Fixed by #41523
Closed
Tracked by #41316

goleak in the gctuner.(*memoryLimitTuner).tuning #41524

hawkingrei opened this issue Feb 16, 2023 · 0 comments · Fixed by #41523
Labels
component/test severity/major type/bug The issue is confirmed as a bug.

Comments

@hawkingrei
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

goleak: Errors on successful test run: found unexpected goroutines:
[Goroutine 20408 in state sleep, with time.Sleep on top of the stack:
goroutine 20408 [sleep]:
time.Sleep(0xdf8475800)
	/opt/homebrew/Cellar/go/1.19.5/libexec/src/runtime/time.go:195 +0x118
github.com/pingcap/tidb/util/gctuner.(*memoryLimitTuner).tuning.func1()
	/Users/weizhenwang/devel/opensource/tidb/util/gctuner/memory_limit_tuner.go:74 +0x10c
created by github.com/pingcap/tidb/util/gctuner.(*memoryLimitTuner).tuning
	/Users/weizhenwang/devel/opensource/tidb/util/gctuner/memory_limit_tuner.go:64 +0x15c
]

4. What is your TiDB version? (Required)
@hawkingrei hawkingrei added the type/bug The issue is confirmed as a bug. label Feb 16, 2023
@hawkingrei hawkingrei mentioned this issue Feb 16, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot added may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 may-affects-6.4 may-affects-6.5 may-affects-6.6 labels Feb 16, 2023
@hawkingrei hawkingrei added component/test and removed may-affects-4.0 This bug maybe affects 4.0.x versions. may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-5.0 This bug maybe affects 5.0.x versions. may-affects-6.0 may-affects-6.1 may-affects-6.2 may-affects-6.3 may-affects-6.4 may-affects-6.5 may-affects-6.6 labels Feb 16, 2023
@hawkingrei hawkingrei mentioned this issue Feb 16, 2023
Open
ti-chi-bot pushed a commit that referenced this issue Feb 16, 2023
@hawkingrei
gctuner: fix goleak in the memoryLimitTuner.tuning (#41523)
218ca1c 
close #41524
@hawkingrei hawkingrei mentioned this issue Feb 18, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
component/test severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

gctuner: fix goleak in the memoryLimitTuner.tuning hawkingrei/tidb
2 participants
@hawkingrei @ti-chi-bot