Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DATA RACE at the regionJob.stage #42301

Closed
Tracked by #41316
hawkingrei opened this issue Mar 16, 2023 · 2 comments · Fixed by #42680
Closed
Tracked by #41316

DATA RACE at the regionJob.stage #42301

hawkingrei opened this issue Mar 16, 2023 · 2 comments · Fixed by #42680
Assignees
Labels
component/test severity/minor type/bug The issue is confirmed as a bug.

Comments

@hawkingrei
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

==================
WARNING: DATA RACE
Read at 0x00c000195078 by goroutine 48:
  github.com/pingcap/tidb/br/pkg/lightning/backend/local.TestCheckPeersBusy()
      br/pkg/lightning/backend/local/local_test.go:1285 +0x27fa
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47
Previous write at 0x00c000195078 by goroutine 60:
  github.com/pingcap/tidb/br/pkg/lightning/backend/local.(*regionJob).convertStageTo()
      br/pkg/lightning/backend/local/region_job.go:92 +0x68
  github.com/pingcap/tidb/br/pkg/lightning/backend/local.(*regionJob).writeToTiKV()
      br/pkg/lightning/backend/local/region_job.go:330 +0x4986
  github.com/pingcap/tidb/br/pkg/lightning/backend/local.(*local).executeJob()
      br/pkg/lightning/backend/local/local.go:1220 +0x364
  github.com/pingcap/tidb/br/pkg/lightning/backend/local.(*local).startWorker()
      br/pkg/lightning/backend/local/local.go:1159 +0x40d
  github.com/pingcap/tidb/br/pkg/lightning/backend/local.TestCheckPeersBusy.func3()
      br/pkg/lightning/backend/local/local_test.go:1275 +0xf2
Goroutine 48 (running) created at:
  testing.(*T).Run()
      GOROOT/src/testing/testing.go:1629 +0x805
  testing.runTests.func1()
      GOROOT/src/testing/testing.go:2036 +0x8d
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.runTests()
      GOROOT/src/testing/testing.go:2034 +0x87c
  testing.(*M).Run()
      GOROOT/src/testing/testing.go:1906 +0xb44
  main.main()
      bazel-out/k8-fastbuild/bin/br/pkg/lightning/backend/local/local_test_/testmain.go:198 +0x5d0
Goroutine 60 (running) created at:
  github.com/pingcap/tidb/br/pkg/lightning/backend/local.TestCheckPeersBusy()
      br/pkg/lightning/backend/local/local_test.go:1273 +0x26c5
  testing.tRunner()
      GOROOT/src/testing/testing.go:1576 +0x216
  testing.(*T).Run.func1()
      GOROOT/src/testing/testing.go:1629 +0x47
================== 

4. What is your TiDB version? (Required)

@hawkingrei hawkingrei added the type/bug The issue is confirmed as a bug. label Mar 16, 2023
@lance6716 lance6716 self-assigned this Mar 16, 2023
@lance6716
Copy link
Contributor

Can you provide the CI link? I need the log to know if the sleep is too short or too long

@hawkingrei
Copy link
Member Author

Can you provide the CI link? I need the log to know if the sleep is too short or too long

https://prow.hawkingrei.com/view/gs/prowpingcap/logs/tidb_race/1640942001295724544

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/test severity/minor type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants