Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade failure Re-upgrade may cause paused system DDL job can't be executed or dirty data of DDL job #44158

Closed
Tracked by #39751
zimulala opened this issue May 25, 2023 · 0 comments · Fixed by #44469
Closed
Tracked by #39751

Upgrade failure Re-upgrade may cause paused system DDL job can't be executed or dirty data of DDL job #44158

zimulala opened this issue May 25, 2023 · 0 comments · Fixed by #44469
Assignees
@zimulala
Labels
affects-7.1 feature/developing the related feature is in development severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.

Comments

@zimulala
Copy link
Contributor

zimulala commented May 25, 2023 •
edited
Loading

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Mock： do upgradeNewVer： Add a new mysql.table(New TiDB upgrade failed, and the DDL is queuing, such as TiKV network problems)
Restart the TiDB. And the TiDB do ResumeAllJobsBySystem failed.

2. What did you expect to see? (Required)

The upgrade succeeds.

3. What did you see instead (Required)

The upgrade may fail because of paused system DDL. But as a DDL job of Add a new mysql.table may be paused in DDL table

4. What is your TiDB version? (Required)

master
@zimulala zimulala added type/bug The issue is confirmed as a bug. affects-7.1 labels May 25, 2023
@zimulala zimulala mentioned this issue May 25, 2023
Closed
17 tasks
@zimulala zimulala added the feature/developing the related feature is in development label May 25, 2023
@zimulala zimulala mentioned this issue May 25, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot bot added may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels May 26, 2023
@seiya-annie seiya-annie added the sig/sql-infra SIG: SQL Infra label May 26, 2023
@zimulala zimulala added severity/moderate severity/major and removed may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 severity/major severity/moderate labels May 31, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Jun 6, 2023
@zimulala zimulala changed the title Upgrade failure Re-upgrade may cause dirty data of DDL job Upgrade failure Re-upgrade may cause paused system DDL job can't be executed or dirty data of DDL job Jun 6, 2023
@zimulala zimulala removed may-affects-5.1 This bug maybe affects 5.1.x versions. may-affects-5.2 This bug maybe affects 5.2.x versions. may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-6.5 labels Jun 7, 2023
@zimulala zimulala mentioned this issue Jun 7, 2023
Merged
12 tasks
@ti-chi-bot ti-chi-bot mentioned this issue Jun 12, 2023
Merged
12 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 12, 2023
@ti-chi-bot
ddl, session: fix re-upgrade issues (#44469) (#44582)
5af21fd 
close #44158
@tiancaiamao tiancaiamao mentioned this issue Jul 18, 2023
Merged
17 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zimulala zimulala

Labels
affects-7.1 feature/developing the related feature is in development severity/major sig/sql-infra SIG: SQL Infra type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ddl, session: fix re-upgrade issues zimulala/tidb
2 participants
@zimulala @seiya-annie