Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: attach the right resource group name in kv request for ddl/import tasks #46656

Closed
glorv opened this issue Sep 5, 2023 · 2 comments · Fixed by #46902
Closed

ddl: attach the right resource group name in kv request for ddl/import tasks #46656

glorv opened this issue Sep 5, 2023 · 2 comments · Fixed by #46902
Assignees
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@glorv
Copy link
Contributor

glorv commented Sep 5, 2023

Development Task

The resource control feature implements quota limiter and scheduling logic in the client-go and tikv side, it uses the resource group name in the kv request to identify the task attached resource group.

For most foreground SQLs, we set the resource-group-name parameter from the sessionctx but for DDL/Import like task, it uses a unified worker pool so the sessionctx's resource group is not the same as the user's session. We should attach the correct resource-group-name to let resource control feature work correctly.

@glorv glorv added the type/enhancement The issue or PR belongs to an enhancement. label Sep 5, 2023
@glorv
Copy link
Contributor Author

glorv commented Sep 5, 2023

/cc @zimulala

@okJiang
Copy link
Member

okJiang commented Sep 7, 2023

Can you tell me where set the resource-group-name parameter from the sessionctx? I will have a look. @glorv

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants