Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DDL maybe block forever if owner is restart or progress the schema change unexpectedly #46920

Closed
wjhuang2016 opened this issue Sep 12, 2023 · 0 comments · Fixed by #46921
Closed
Labels
affects-6.5 affects-7.1 component/ddl This issue is related to DDL of TiDB. priority/release-blocker This issue blocks a release. Please solve it ASAP. severity/critical type/bug The issue is confirmed as a bug.

Comments

@wjhuang2016
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Given two tables, namely t1, t2.
And two TiDB servers, tidb1(ddl owner), tidb2.
Note: It may not reproduce for 2 tables/DDLs, you can extend to 3 tables/DDLs.

  1. connect to tidb 2. Do:
begin;
select * from t1, t2;
  1. connect to tidb 2. Do:
alter table t1 add column b int;
  1. connect to tidb 2. Do:
alter table t2 add column b int;
  1. restart/close/kill TiDB1(owner)
  2. commit the transaction in step1 session.

2. What did you expect to see? (Required)

Two DDL success finally.

3. What did you see instead (Required)

The first DDL success finally, but the second DDL block forever(even with restarting the whole cluster),

4. What is your TiDB version? (Required)

6.5, (7.1, master) No blocking, but progress the schema change unexpectedly .

@wjhuang2016 wjhuang2016 added the type/bug The issue is confirmed as a bug. label Sep 12, 2023
@wjhuang2016 wjhuang2016 added affects-6.5 affects-7.1 priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Sep 12, 2023
@jebter jebter added component/ddl This issue is related to DDL of TiDB. severity/critical labels Sep 13, 2023
@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Sep 13, 2023
@wjhuang2016 wjhuang2016 removed may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Sep 14, 2023
ti-chi-bot bot pushed a commit that referenced this issue Sep 20, 2023
wjhuang2016 added a commit to ti-chi-bot/tidb that referenced this issue Nov 23, 2023
@wjhuang2016 wjhuang2016 changed the title DDL maybe block forever is owner is restart or progress the schema change unexpectedly DDL maybe block forever is owner if restart or progress the schema change unexpectedly Nov 28, 2023
@wjhuang2016 wjhuang2016 changed the title DDL maybe block forever is owner if restart or progress the schema change unexpectedly DDL maybe block forever if owner is restart or progress the schema change unexpectedly Nov 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
affects-6.5 affects-7.1 component/ddl This issue is related to DDL of TiDB. priority/release-blocker This issue blocks a release. Please solve it ASAP. severity/critical type/bug The issue is confirmed as a bug.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants