Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chunks cannot be re-used across multiple GetMatchedRowsAndPtrs calls #48082

Closed
YangKeao opened this issue Oct 30, 2023 · 6 comments · Fixed by #48090
Closed

Chunks cannot be re-used across multiple GetMatchedRowsAndPtrs calls #48082

YangKeao opened this issue Oct 30, 2023 · 6 comments · Fixed by #48090
Assignees
@wshwsh12
Labels
affects-6.5 affects-7.1 affects-7.5 severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug. type/performance type/regression

Comments

@YangKeao
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

Run the benchmark BenchmarkHashJoinExec

2. What did you expect to see? (Required)

Allocating chunks will not cost too much resources.

3. What did you see instead (Required)

Allocating chunks takes a large percent of the total profiling.

Ref: #41081.
@YangKeao YangKeao added type/bug The issue is confirmed as a bug. affects-6.5 affects-7.1 sig/execution SIG execution labels Oct 30, 2023
@wshwsh12 wshwsh12 mentioned this issue Oct 30, 2023
Merged
13 tasks
@ti-chi-bot ti-chi-bot bot added may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 may-affects-7.5 labels Oct 30, 2023
@wshwsh12 wshwsh12 added affects-7.5 and removed may-affects-5.3 This bug maybe affects 5.3.x versions. may-affects-5.4 This bug maybe affects 5.4.x versions. may-affects-6.1 labels Oct 30, 2023
@winoros
Copy link
Member

winoros commented Oct 30, 2023

So why does ARM suffer much more compared with x86?

ti-chi-bot bot pushed a commit that referenced this issue Oct 30, 2023
@wshwsh12
executor: reuse chunk for GetMatchedRowsAndPtrs calls (#48090)
f8ca23c 
close #48082
This was referenced Oct 30, 2023
Merged
Merged
Merged
@XuHuaiyu
Copy link
Contributor

@winoros X86 uses v6.1, the bug code does not exist.
ARM uses v6.5.

lcwangchao pushed a commit to lcwangchao/tidb that referenced this issue Oct 31, 2023
@wshwsh12 @lcwangchao
executor: reuse chunk for GetMatchedRowsAndPtrs calls (pingcap#48090)
390060b 
close pingcap#48082
@lcwangchao lcwangchao mentioned this issue Oct 31, 2023
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Oct 31, 2023
@lcwangchao
executor: reuse chunk for GetMatchedRowsAndPtrs calls (#48090) (#48134)
795585b 
close #48082
@winoros
Copy link
Member

winoros commented Nov 2, 2023

@winoros X86 uses v6.1, the bug code does not exist. ARM uses v6.5.

😂 Reasonable!

ti-chi-bot bot pushed a commit that referenced this issue Nov 3, 2023
@ti-chi-bot
executor: reuse chunk for GetMatchedRowsAndPtrs calls (#48090) (#48103)
9e55944 
close #48082
ti-chi-bot bot pushed a commit that referenced this issue Nov 3, 2023
@ti-chi-bot
executor: reuse chunk for GetMatchedRowsAndPtrs calls (#48090) (#48105)
090f77e 
close #48082
ti-chi-bot bot pushed a commit that referenced this issue Nov 7, 2023
@ti-chi-bot
executor: reuse chunk for GetMatchedRowsAndPtrs calls (#48090) (#48106)
817b4fc 
close #48082
@kennedy8312
Copy link

/type regression

@kennedy8312
Copy link

Regression Analysis
Issue didn't show up v6.1.6+x86 but v6.5.3+arm.

@kennedy8312
Copy link

/type performance

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wshwsh12 wshwsh12

Labels
affects-6.5 affects-7.1 affects-7.5 severity/major sig/execution SIG execution type/bug The issue is confirmed as a bug. type/performance type/regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

executor: reuse chunk for GetMatchedRowsAndPtrs calls wshwsh12/tidb
5 participants
@YangKeao @winoros @XuHuaiyu @wshwsh12 @kennedy8312