Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we keep EnablePointGetCache realted codes? #48958

Closed
Defined2014 opened this issue Nov 28, 2023 · 1 comment
Closed

Should we keep EnablePointGetCache realted codes? #48958

Defined2014 opened this issue Nov 28, 2023 · 1 comment
Labels
affects-8.1 severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.

Comments

@Defined2014
Copy link
Contributor

Defined2014 commented Nov 28, 2023 •
edited
Loading

Enhancement

We can only enable EnablePointGetCache by golang code rather than a global variable. And its default value is false which means it nerver be used anytime.

The realed global variable is deleted by #36844.

(Seems #36844 is a mistake, maybe we could add it back or totally remove it.
@Defined2014 Defined2014 added type/enhancement The issue or PR belongs to an enhancement. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. and removed help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Nov 28, 2023
@Defined2014 Defined2014 self-assigned this Nov 28, 2023
@Defined2014 Defined2014 mentioned this issue Nov 28, 2023
Closed
13 tasks
@Defined2014 Defined2014 changed the title Remove EnablePointGetCache realted codes. Remove EnablePointGetCache realted codes Nov 28, 2023
@Defined2014 Defined2014 removed their assignment Nov 29, 2023
@Defined2014 Defined2014 added type/bug The issue is confirmed as a bug. severity/major and removed type/enhancement The issue or PR belongs to an enhancement. labels Dec 5, 2023
@Defined2014 Defined2014 changed the title Remove EnablePointGetCache realted codes Should we keep EnablePointGetCache realted codes? Dec 5, 2023
@Defined2014 Defined2014 mentioned this issue Feb 6, 2024
Closed
13 tasks
@qw4990
Copy link
Contributor

qw4990 commented Apr 26, 2024

Duplicated with #51007

@qw4990 qw4990 closed this as completed Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
affects-8.1 severity/major sig/planner SIG: Planner type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
3 participants
@qw4990 @Defined2014 @ti-chi-bot