Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: remove EnablePointGetCache and cacheDB #48962

Closed

Conversation

Defined2014
Copy link
Contributor

@Defined2014 Defined2014 commented Nov 28, 2023

What problem does this PR solve?

Issue Number: close #48958

Problem Summary:

We can only enable EnablePointGetCache by golang code rather than a global variable (like test used). And its default value is false which means it nerver be used anytime.

Also we could remove cacheDB and cacheBatchGetter etc.

The realed global variable is deleted by #36844.

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None

@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. labels Nov 28, 2023
Copy link

ti-chi-bot bot commented Nov 28, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign gmhdbjd, yudongusa for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

Copy link

tiprow bot commented Nov 28, 2023

Hi @Defined2014. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link

codecov bot commented Nov 28, 2023

Codecov Report

Merging #48962 (686425b) into master (1456c9d) will increase coverage by 1.6460%.
Report is 3 commits behind head on master.
The diff coverage is 100.0000%.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #48962        +/-   ##
================================================
+ Coverage   70.9941%   72.6401%   +1.6460%     
================================================
  Files          1368       1389        +21     
  Lines        404987     411092      +6105     
================================================
+ Hits         287517     298618     +11101     
+ Misses        97448      93616      -3832     
+ Partials      20022      18858      -1164     
Flag Coverage Δ
integration 43.6201% <100.0000%> (?)
unit 70.9932% <ø> (-0.0009%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.9663% <ø> (ø)
parser ∅ <ø> (∅)
br 48.8110% <ø> (-4.2698%) ⬇️

@Defined2014 Defined2014 closed this Dec 8, 2023
@Defined2014 Defined2014 deleted the remove-enable-point-get-cache branch December 8, 2023 07:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release-note-none Denotes a PR that doesn't merit a release note. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Should we keep EnablePointGetCache realted codes?
1 participant