Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove GetSessionVars and Value/GetValue in expression.BuildContext #52366

Closed
lcwangchao opened this issue Apr 7, 2024 · 0 comments · Fixed by #52367, #52468 or #52528
Closed

Remove GetSessionVars and Value/GetValue in expression.BuildContext #52366

lcwangchao opened this issue Apr 7, 2024 · 0 comments · Fixed by #52367, #52468 or #52528
Labels
type/enhancement The issue or PR belongs to an enhancement.

Comments

@lcwangchao
Copy link
Collaborator

lcwangchao commented Apr 7, 2024

Enhancement

It's better to remove some methods like Value, SetValue or GetSessionVars in expression.BuildContext because these methods are too common and contain too many fields even they are not used in BuildContext. These methods makes it's hard to mock or build a standalone context without a session enviroment.

@lcwangchao lcwangchao added the type/enhancement The issue or PR belongs to an enhancement. label Apr 7, 2024
ti-chi-bot bot pushed a commit that referenced this issue Apr 9, 2024
ti-chi-bot bot pushed a commit that referenced this issue Apr 11, 2024
ti-chi-bot bot pushed a commit that referenced this issue Apr 11, 2024
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this issue Apr 16, 2024
3AceShowHand pushed a commit to 3AceShowHand/tidb that referenced this issue Apr 16, 2024
ti-chi-bot bot pushed a commit that referenced this issue Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment