Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flaky test TestSkipSchemaChecker #53427

Closed
Tracked by #41316
hawkingrei opened this issue May 21, 2024 · 0 comments · Fixed by #54367
Closed
Tracked by #41316

flaky test TestSkipSchemaChecker #53427

hawkingrei opened this issue May 21, 2024 · 0 comments · Fixed by #54367
Assignees
@tangenta
Labels
component/ddl This issue is related to DDL of TiDB. component/test severity/major type/bug The issue is confirmed as a bug.

Comments

@hawkingrei
Copy link
Member

Bug Report

Please answer these questions before submitting your issue. Thanks!

1. Minimal reproduce step (Required)

2. What did you expect to see? (Required)

3. What did you see instead (Required)

     testkit.go:158: 
        	Error Trace:	pkg/testkit/testkit.go:158
        	            				pkg/testkit/testkit.go:151
        	            				pkg/ddl/tiflash_replica_test.go:265
        	Error:      	Received unexpected error:
        	            	[domain:8028]Information schema is changed during the execution of the statement(for example, table definition may be updated by other DDL ran in parallel). If you see this error often, try increasing `tidb_max_delta_schema_count`. [try again later]
        	            	github.com/tikv/client-go/v2/txnkv/transaction.(*twoPhaseCommitter).checkSchemaValid
        	            		external/com_github_tikv_client_go_v2/txnkv/transaction/2pc.go:1871
        	            	github.com/tikv/client-go/v2/txnkv/transaction.(*twoPhaseCommitter).execute
        	            		external/com_github_tikv_client_go_v2/txnkv/transaction/2pc.go:1694
        	            	github.com/tikv/client-go/v2/txnkv/transaction.(*KVTxn).Commit
        	            		external/com_github_tikv_client_go_v2/txnkv/transaction/txn.go:714
        	            	github.com/pingcap/tidb/pkg/store/driver/txn.(*tikvTxn).Commit
        	            		pkg/store/driver/txn/txn_driver.go:113
        	            	github.com/pingcap/tidb/pkg/session.(*LazyTxn).Commit
        	            		pkg/session/txn.go:441
        	            	github.com/pingcap/tidb/pkg/session.(*session).commitTxnWithTemporaryData
        	            		pkg/session/session.go:666
        	            	github.com/pingcap/tidb/pkg/session.(*session).doCommit
        	            		pkg/session/session.go:546
        	            	github.com/pingcap/tidb/pkg/session.(*session).doCommitWithRetry
        	            		pkg/session/session.go:788
        	            	github.com/pingcap/tidb/pkg/session.(*session).CommitTxn
        	            		pkg/session/session.go:918
        	            	github.com/pingcap/tidb/pkg/session.autoCommitAfterStmt
        	            		pkg/session/tidb.go:281
        	            	github.com/pingcap/tidb/pkg/session.finishStmt
        	            		pkg/session/tidb.go:243
        	            	github.com/pingcap/tidb/pkg/session.runStmt
        	            		pkg/session/session.go:2316
        	            	github.com/pingcap/tidb/pkg/session.(*session).ExecuteStmt
        	            		pkg/session/session.go:2146
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).ExecWithContext
        	            		pkg/testkit/testkit.go:384
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).MustExecWithContext
        	            		pkg/testkit/testkit.go:156
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).MustExec
        	            		pkg/testkit/testkit.go:151
        	            	github.com/pingcap/tidb/pkg/ddl_test.TestSkipSchemaChecker
        	            		pkg/ddl/tiflash_replica_test.go:265
        	            	testing.tRunner
        	            		GOROOT/src/testing/testing.go:1595
        	            	runtime.goexit
        	            		src/runtime/asm_amd64.s:1650
        	            	github.com/pingcap/errors.AddStack
        	            		external/com_github_pingcap_errors/errors.go:178
        	            	github.com/pingcap/errors.Trace
        	            		external/com_github_pingcap_errors/juju_adaptor.go:15
        	            	github.com/pingcap/tidb/pkg/store/driver/error.ToTiDBErr
        	            		pkg/store/driver/error/error.go:200
        	            	github.com/pingcap/tidb/pkg/store/driver/txn.extractKeyErr
        	            		pkg/store/driver/txn/error.go:164
        	            	github.com/pingcap/tidb/pkg/store/driver/txn.(*tikvTxn).extractKeyErr
        	            		pkg/store/driver/txn/txn_driver.go:340
        	            	github.com/pingcap/tidb/pkg/store/driver/txn.(*tikvTxn).Commit
        	            		pkg/store/driver/txn/txn_driver.go:114
        	            	github.com/pingcap/tidb/pkg/session.(*LazyTxn).Commit
        	            		pkg/session/txn.go:441
        	            	github.com/pingcap/tidb/pkg/session.(*session).commitTxnWithTemporaryData
        	            		pkg/session/session.go:666
        	            	github.com/pingcap/tidb/pkg/session.(*session).doCommit
        	            		pkg/session/session.go:546
        	            	github.com/pingcap/tidb/pkg/session.(*session).doCommitWithRetry
        	            		pkg/session/session.go:788
        	            	github.com/pingcap/tidb/pkg/session.(*session).CommitTxn
        	            		pkg/session/session.go:918
        	            	github.com/pingcap/tidb/pkg/session.autoCommitAfterStmt
        	            		pkg/session/tidb.go:281
        	            	github.com/pingcap/tidb/pkg/session.finishStmt
        	            		pkg/session/tidb.go:243
        	            	github.com/pingcap/tidb/pkg/session.runStmt
        	            		pkg/session/session.go:2316
        	            	github.com/pingcap/tidb/pkg/session.(*session).ExecuteStmt
        	            		pkg/session/session.go:2146
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).ExecWithContext
        	            		pkg/testkit/testkit.go:384
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).MustExecWithContext
        	            		pkg/testkit/testkit.go:156
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).MustExec
        	            		pkg/testkit/testkit.go:151
        	            	github.com/pingcap/tidb/pkg/ddl_test.TestSkipSchemaChecker
        	            		pkg/ddl/tiflash_replica_test.go:265
        	            	testing.tRunner
        	            		GOROOT/src/testing/testing.go:1595
        	            	runtime.goexit
        	            		src/runtime/asm_amd64.s:1650
        	            	previous statement: insert into t1 set a=1;
        	Test:       	TestSkipSchemaChecker
        	Messages:   	sql:commit, [], error stack [domain:8028]Information schema is changed during the execution of the statement(for example, table definition may be updated by other DDL ran in parallel). If you see this error often, try increasing `tidb_max_delta_schema_count`. [try again later]
        	            	github.com/tikv/client-go/v2/txnkv/transaction.(*twoPhaseCommitter).checkSchemaValid
        	            		external/com_github_tikv_client_go_v2/txnkv/transaction/2pc.go:1871
        	            	github.com/tikv/client-go/v2/txnkv/transaction.(*twoPhaseCommitter).execute
        	            		external/com_github_tikv_client_go_v2/txnkv/transaction/2pc.go:1694
        	            	github.com/tikv/client-go/v2/txnkv/transaction.(*KVTxn).Commit
        	            		external/com_github_tikv_client_go_v2/txnkv/transaction/txn.go:714
        	            	github.com/pingcap/tidb/pkg/store/driver/txn.(*tikvTxn).Commit
        	            		pkg/store/driver/txn/txn_driver.go:113
        	            	github.com/pingcap/tidb/pkg/session.(*LazyTxn).Commit
        	            		pkg/session/txn.go:441
        	            	github.com/pingcap/tidb/pkg/session.(*session).commitTxnWithTemporaryData
        	            		pkg/session/session.go:666
        	            	github.com/pingcap/tidb/pkg/session.(*session).doCommit
        	            		pkg/session/session.go:546
        	            	github.com/pingcap/tidb/pkg/session.(*session).doCommitWithRetry
        	            		pkg/session/session.go:788
        	            	github.com/pingcap/tidb/pkg/session.(*session).CommitTxn
        	            		pkg/session/session.go:918
        	            	github.com/pingcap/tidb/pkg/session.autoCommitAfterStmt
        	            		pkg/session/tidb.go:281
        	            	github.com/pingcap/tidb/pkg/session.finishStmt
        	            		pkg/session/tidb.go:243
        	            	github.com/pingcap/tidb/pkg/session.runStmt
        	            		pkg/session/session.go:2316
        	            	github.com/pingcap/tidb/pkg/session.(*session).ExecuteStmt
        	            		pkg/session/session.go:2146
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).ExecWithContext
        	            		pkg/testkit/testkit.go:384
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).MustExecWithContext
        	            		pkg/testkit/testkit.go:156
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).MustExec
        	            		pkg/testkit/testkit.go:151
        	            	github.com/pingcap/tidb/pkg/ddl_test.TestSkipSchemaChecker
        	            		pkg/ddl/tiflash_replica_test.go:265
        	            	testing.tRunner
        	            		GOROOT/src/testing/testing.go:1595
        	            	runtime.goexit
        	            		src/runtime/asm_amd64.s:1650
        	            	github.com/pingcap/errors.AddStack
        	            		external/com_github_pingcap_errors/errors.go:178
        	            	github.com/pingcap/errors.Trace
        	            		external/com_github_pingcap_errors/juju_adaptor.go:15
        	            	github.com/pingcap/tidb/pkg/store/driver/error.ToTiDBErr
        	            		pkg/store/driver/error/error.go:200
        	            	github.com/pingcap/tidb/pkg/store/driver/txn.extractKeyErr
        	            		pkg/store/driver/txn/error.go:164
        	            	github.com/pingcap/tidb/pkg/store/driver/txn.(*tikvTxn).extractKeyErr
        	            		pkg/store/driver/txn/txn_driver.go:340
        	            	github.com/pingcap/tidb/pkg/store/driver/txn.(*tikvTxn).Commit
        	            		pkg/store/driver/txn/txn_driver.go:114
        	            	github.com/pingcap/tidb/pkg/session.(*LazyTxn).Commit
        	            		pkg/session/txn.go:441
        	            	github.com/pingcap/tidb/pkg/session.(*session).commitTxnWithTemporaryData
        	            		pkg/session/session.go:666
        	            	github.com/pingcap/tidb/pkg/session.(*session).doCommit
        	            		pkg/session/session.go:546
        	            	github.com/pingcap/tidb/pkg/session.(*session).doCommitWithRetry
        	            		pkg/session/session.go:788
        	            	github.com/pingcap/tidb/pkg/session.(*session).CommitTxn
        	            		pkg/session/session.go:918
        	            	github.com/pingcap/tidb/pkg/session.autoCommitAfterStmt
        	            		pkg/session/tidb.go:281
        	            	github.com/pingcap/tidb/pkg/session.finishStmt
        	            		pkg/session/tidb.go:243
        	            	github.com/pingcap/tidb/pkg/session.runStmt
        	            		pkg/session/session.go:2316
        	            	github.com/pingcap/tidb/pkg/session.(*session).ExecuteStmt
        	            		pkg/session/session.go:2146
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).ExecWithContext
        	            		pkg/testkit/testkit.go:384
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).MustExecWithContext
        	            		pkg/testkit/testkit.go:156
        	            	github.com/pingcap/tidb/pkg/testkit.(*TestKit).MustExec
        	            		pkg/testkit/testkit.go:151
        	            	github.com/pingcap/tidb/pkg/ddl_test.TestSkipSchemaChecker
        	            		pkg/ddl/tiflash_replica_test.go:265
        	            	testing.tRunner
        	            		GOROOT/src/testing/testing.go:1595
        	            	runtime.goexit
        	            		src/runtime/asm_amd64.s:1650
        	            	previous statement: insert into t1 set a=1;

https://tiprow.hawkingrei.com/view/gs/pingcapprow/pr-logs/pull/pingcap_tidb/53399/fast_test_tiprow/1792745235722276864

4. What is your TiDB version? (Required)
@hawkingrei hawkingrei added type/bug The issue is confirmed as a bug. component/test labels May 21, 2024
@hawkingrei hawkingrei mentioned this issue May 21, 2024
Open
@jebter jebter added component/ddl This issue is related to DDL of TiDB. severity/major labels May 22, 2024
@tangenta tangenta self-assigned this May 24, 2024
@tangenta tangenta mentioned this issue Jul 1, 2024
Merged
13 tasks
ti-chi-bot bot pushed a commit that referenced this issue Jul 1, 2024
@tangenta
test: stabilize TestSkipSchemaChecker (#54367)
cbb7e64 
close #53427
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tangenta tangenta

Labels
component/ddl This issue is related to DDL of TiDB. component/test severity/major type/bug The issue is confirmed as a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test: stabilize TestSkipSchemaChecker tangenta/tidb
3 participants
@hawkingrei @jebter @tangenta