Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix static analysis issues #7247

Closed
gregwebs opened this issue Aug 2, 2018 · 3 comments
Closed

Fix static analysis issues #7247

gregwebs opened this issue Aug 2, 2018 · 3 comments
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.

Comments

@gregwebs
Copy link
Contributor

gregwebs commented Aug 2, 2018

#7240 is showing many issues in static analysis. After that is merged, run make check-fail. The most important to fix is probably errcheck and gosec.
@gregwebs gregwebs added help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines. good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. labels Aug 2, 2018
@gregwebs gregwebs mentioned this issue Aug 2, 2018
Merged
@ngaut ngaut closed this as completed Aug 2, 2018
@lysu lysu reopened this Aug 2, 2018
@winoros
Copy link
Member

winoros commented Sep 13, 2018

related issue: #3120

@gregwebs
Copy link
Contributor Author

A PR was just sent to fix some issues: #8101

This site can be used to check progress on some of these: https://goreportcard.com/report/github.com/pingcap/tidb

@ghost
Copy link

ghost commented Jul 30, 2020

I am going to close this issue as stale. Please feel free to re-open if there are additional issues. Thanks!

@ghost ghost closed this as completed Jul 30, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Denotes an issue ready for a new contributor, according to the "help wanted" guidelines. help wanted Denotes an issue that needs help from a contributor. Must meet "help wanted" guidelines.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gregwebs @lysu @ngaut @winoros