*: Add few error checks in tests, clean error messages and fix one misspell #8101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi contributor, thanks for your PR. This patch needs to be approved by someone of admins. They should reply with "/ok-to-test" to accept this PR for running test automatically. |
|
@dvrkps Thanks! |
crazycs520
reviewed
Oct 30, 2018
ddl/db_change_test.go
Outdated
| @@ -588,6 +588,7 @@ func (s *testStateChangeSuite) TestShowIndex(c *C) { | |||
| result, err = s.execQuery(tk, "show index from tr;") | |||
| c.Assert(err, IsNil) | |||
| err = checkResult(result, testkit.Rows("tr 1 idx1 1 purchased A 0 <nil> <nil> BTREE ", "t 1 c2 1 c2 A 0 <nil> <nil> YES BTREE ")) | |||
There was a problem hiding this comment.
the test was wrong.
err = checkResult(result, testkit.Rows("tr 1 idx1 1 purchased A 0 <nil> <nil> YES BTREE "))There was a problem hiding this comment.
@crazycs520 Done. Thx.
util/encrypt/crypt_test.go
Outdated
| @@ -72,8 +72,8 @@ func (s *testEncryptSuite) TestSQLEncode(c *C) { | |||
|
|
|||
| for _, t := range tests { | |||
| crypted, err := SQLDecode(t.str, t.passwd) | |||
| c.Assert(err, NotNil) | |||
There was a problem hiding this comment.
@crazycs520 Done. Thx.
expression/integration_test.go
Outdated
| @@ -3127,6 +3127,7 @@ func (s *testIntegrationSuite) TestDateBuiltin(c *C) { | |||
|
|
|||
| tk.MustExec("set sql_mode = 'NO_ZERO_DATE'") | |||
| rs, err := tk.Exec("select date '0000-00-00';") | |||
| c.Assert(err, NotNil) | |||
There was a problem hiding this comment.
@crazycs520 Done. Thx.
expression/integration_test.go
Outdated
| @@ -3156,6 +3157,7 @@ func (s *testIntegrationSuite) TestDateBuiltin(c *C) { | |||
| c.Assert(rs.Close(), IsNil) | |||
|
|
|||
| rs, err = tk.Exec("select date '0000-00-00';") | |||
| c.Assert(err, NotNil) | |||
There was a problem hiding this comment.
@crazycs520 Done. Thx.
|
@dvrkps thank you! Lets see if we can get some of these added to the linting/ci now. |
zz-jason
added
component/test
status/LGT1
zz-jason
changed the title
|
@crazycs520 Can we turn on any new linters in the Makefile now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.