executor: use EncodeBytes in countOriginDistinct #10107
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
XuHuaiyu
force-pushed
the
count_distinct
branch
from
ae8ee54
to
78b1c7b
Compare
eurekaka
reviewed
Apr 11, 2019
| @@ -329,7 +331,7 @@ func (e *countOriginalWithDistinct) evalAndEncode( | |||
| if err != nil || isNull { | |||
| break | |||
| } | |||
| encodedBytes = appendString(encodedBytes, buf, val) | |||
| encodedBytes = codec.EncodeBytes(encodedBytes, hack.Slice(val)) | |||
There was a problem hiding this comment.
Looks like appendJSON has risk as well theoretically?
There was a problem hiding this comment.
Yes, I'll change it.
But it a little difficult to write tests for it.
Codecov Report
@@ Coverage Diff @@
## master #10107 +/- ##
===============================================
- Coverage 77.952% 77.9509% -0.0012%
===============================================
Files 407 407
Lines 83264 83296 +32
===============================================
+ Hits 64906 64930 +24
- Misses 13549 13555 +6
- Partials 4809 4811 +2 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix issue #10099
What is changed and how it works?
Use EncodeBytes to encode string values in countOriginalWithDistinct.
Before this commit, string values are encoded with true values.
e.g.
encode("1", "122") --> "1122"
encode("11", "22") --> "1222"
These are not comparable.
Check List
Tests
Code changes
Side effects
N/A
Related changes