Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

infoschema/slow_query: fix slow log parser bug when sql contain # #10271

Merged
merged 1 commit into from
Apr 25, 2019
Merged

infoschema/slow_query: fix slow log parser bug when sql contain # #10271

merged 1 commit into from
Apr 25, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

fix slow log parser bug when sql contain '# '.

What is changed and how it works?

Change parser function.

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

@crazycs520 crazycs520 added the type/bugfix This PR fixes a bug. label Apr 25, 2019
alivxxx
alivxxx reviewed Apr 25, 2019
View reviewed changes
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 25, 2019
lysu
lysu approved these changes Apr 25, 2019
View reviewed changes
Copy link
Contributor

@lysu lysu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor Author

/run-all-tests

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-all-tests

@lysu lysu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 25, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-all-tests

@mahjonp
Copy link
Contributor

mahjonp commented Apr 25, 2019

/rebuild

@mahjonp
Copy link
Contributor

mahjonp commented Apr 25, 2019

/run-all-tests

1 similar comment
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520 crazycs520 merged commit 4f1f535 into pingcap:master Apr 25, 2019
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Apr 25, 2019
@crazycs520
infoschema/slow_query: fix parser bug when sql contain # (pingcap#10271)
e486f4f
@crazycs520 crazycs520 mentioned this pull request Apr 25, 2019
Merged
zz-jason pushed a commit that referenced this pull request Apr 26, 2019
@crazycs520
infoschema/slow_query: fix parser bug when sql contain # (#10271) (#1…
8e550cd 
…0275)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alivxxx alivxxx alivxxx left review comments

@lysu lysu lysu approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crazycs520 @mahjonp @lysu @alivxxx