Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: support select/ explain select using bind info #10284

Merged
merged 21 commits into from
Apr 29, 2019

Conversation

iamzhoug37
Copy link
Contributor

What problem does this PR solve?

associated iusse: #8935
feature: support add session binding
use case:
create table t(i int, s varchar(20))
create index index_t on t(i,s)
create session binding for select * from t using select * from t use index for join(index_t)
then when we execute select * from t, we will execute select * from t use index for join(index_t) in actually.

What is changed and how it works?

Check List

Tests

  • Unit test
  • Integration test

Code changes
N/A

Side effects
N/A

Related changes
N/A

@codecov
Copy link

codecov bot commented Apr 28, 2019

Codecov Report

Merging #10284 into master will increase coverage by 0.0261%.
The diff coverage is 62.4489%.

@@               Coverage Diff                @@
##             master     #10284        +/-   ##
================================================
+ Coverage   77.7588%   77.7849%   +0.0261%     
================================================
  Files           410        411         +1     
  Lines         85117      84965       -152     
================================================
- Hits          66186      66090        -96     
+ Misses        13979      13937        -42     
+ Partials       4952       4938        -14

@alivxxx
Copy link
Contributor

alivxxx commented Apr 28, 2019

/rebuild

@alivxxx alivxxx requested a review from XuHuaiyu April 28, 2019 09:38
@XuHuaiyu XuHuaiyu added sig/execution SIG execution priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Apr 28, 2019
executor/compiler.go Show resolved Hide resolved
executor/compiler.go Show resolved Hide resolved
session/session.go Outdated Show resolved Hide resolved
bindinfo/bind_test.go Outdated Show resolved Hide resolved
bindinfo/bind_test.go Show resolved Hide resolved
bindinfo/bind_test.go Show resolved Hide resolved
bindinfo/bind_test.go Show resolved Hide resolved
domain/domain.go Show resolved Hide resolved
bindinfo/handle.go Show resolved Hide resolved
executor/compiler.go Show resolved Hide resolved
session/session.go Show resolved Hide resolved
bindinfo/bind.go Show resolved Hide resolved
bindinfo/bind.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
@XuHuaiyu XuHuaiyu changed the title *: "support query binding" *: support query with bindInfo Apr 29, 2019
bindinfo/bind.go Outdated Show resolved Hide resolved
bindinfo/bind.go Outdated Show resolved Hide resolved
bindinfo/bind.go Outdated Show resolved Hide resolved
bindinfo/bind.go Outdated Show resolved Hide resolved
bindinfo/bind.go Outdated Show resolved Hide resolved
executor/compiler.go Outdated Show resolved Hide resolved
executor/compiler.go Outdated Show resolved Hide resolved
session/session.go Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Apr 29, 2019
session/session.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
bindinfo/handle.go Outdated Show resolved Hide resolved
@XuHuaiyu
Copy link
Contributor

/run-all-tests

Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu
Copy link
Contributor

/run-all-tests

@XuHuaiyu XuHuaiyu added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Apr 29, 2019
@XuHuaiyu
Copy link
Contributor

/run-integration-common-test

@XuHuaiyu XuHuaiyu changed the title *: support query with bindInfo *: support select/ explain select using bind info Apr 29, 2019
@XuHuaiyu XuHuaiyu merged commit cd10bca into pingcap:master Apr 29, 2019
@sre-bot sre-bot added the contribution This PR is from a community contributor. label Dec 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
contribution This PR is from a community contributor. priority/release-blocker This issue blocks a release. Please solve it ASAP. sig/execution SIG execution status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants