planner: should clone column in injectProjBelowSort #10452
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
please fix ci and resolve the conflicts @winoros |
Codecov Report
@@ Coverage Diff @@
## master #10452 +/- ##
================================================
+ Coverage 77.7059% 77.7061% +0.0002%
================================================
Files 413 413
Lines 87503 87504 +1
================================================
+ Hits 67995 67996 +1
+ Misses 14359 14358 -1
- Partials 5149 5150 +1 |
|
Since testSuite4 is reopened successfully. |
alivxxx
approved these changes
May 27, 2019
|
/run-all-tests |
db-storage
pushed a commit
to db-storage/tidb
that referenced
this pull request
May 29, 2019
winoros
added a commit
to winoros/tidb
that referenced
this pull request
Jun 5, 2019
zz-jason
pushed a commit
that referenced
this pull request
Jun 5, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
fix #10435
What is changed and how it works?
Clone the column since we don't the output of child's children. So we should not change the index of columns in child.
Check List
Tests
Related changes