Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

go.mod: update parser #10600

Merged
merged 3 commits into from
May 27, 2019
Merged

go.mod: update parser #10600

merged 3 commits into from
May 27, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented May 27, 2019

What problem does this PR solve?

Update parser for parser PR: pingcap/parser#338.

Fix caseExpr format bug.

((case when (c0 = 0) then 0 when (c0 > 0) then (c1 / c0) end))

before

"((CASE WHEN (`c0` = 0) THEN 0WHEN (`c0` > 0) THEN (`c1` / `c0`) END))"

now

"((CASE WHEN (`c0` = 0) THEN 0 WHEN (`c0` > 0) THEN (`c1` / `c0`) END))"

the differents is THEN 0WHEN and THEN 0 WHEN

What is changed and how it works?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

@codecov
Copy link

codecov bot commented May 27, 2019

Codecov Report

Merging #10600 into master will increase coverage by 0.0059%.
The diff coverage is n/a.

@@              Coverage Diff               @@
##             master   #10600        +/-   ##
==============================================
+ Coverage   77.3741%   77.38%   +0.0059%     
==============================================
  Files           413      413                
  Lines         87422    87476        +54     
==============================================
+ Hits          67642    67689        +47     
- Misses        14577    14583         +6     
- Partials       5203     5204         +1

@crazycs520
Copy link
Contributor Author

/run-all-tests

2 similar comments
@zhouqiang-cl
Copy link
Contributor

/run-all-tests

@crazycs520
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label May 27, 2019
Copy link
Member

@jackysp jackysp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jackysp jackysp added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels May 27, 2019
@crazycs520 crazycs520 merged commit e73e251 into pingcap:master May 27, 2019
db-storage pushed a commit to db-storage/tidb that referenced this pull request May 29, 2019
@alivxxx
Copy link
Contributor

alivxxx commented Jun 4, 2019

@crazycs520 Could you cherry pick this PR to release-3.0?

@crazycs520 crazycs520 added the type/bugfix This PR fixes a bug. label Jun 4, 2019
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Jun 4, 2019
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Jun 12, 2019
winkyao pushed a commit that referenced this pull request Jun 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component/parser status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants