Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

*: add config item for bind info lease #10725

Merged
merged 2 commits into from
Jun 5, 2019
Merged

Conversation

alivxxx
Copy link
Contributor

@alivxxx alivxxx commented Jun 5, 2019

What problem does this PR solve?

Fix #9606

What is changed and how it works?

Add one config item for the bind info lease and the default value is 3s.

Check List

Tests

  • Manual test (add detailed scripts or steps below)
    Change the bind info lease to 0 and verifies that the two background goroutine does not exist.

Code changes

  • Has exported function/method change

Side effects

  • None

Related changes

  • Need to cherry-pick to the release branch

@alivxxx alivxxx added the type/enhancement The issue or PR belongs to an enhancement. label Jun 5, 2019
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #10725 into master will increase coverage by 0.0111%.
The diff coverage is 66.6666%.

@@               Coverage Diff                @@
##             master     #10725        +/-   ##
================================================
+ Coverage   79.6565%   79.6676%   +0.0111%     
================================================
  Files           414        414                
  Lines         87817      87865        +48     
================================================
+ Hits          69952      70000        +48     
+ Misses        12682      12680         -2     
- Partials       5183       5185         +2

1 similar comment
@codecov
Copy link

codecov bot commented Jun 5, 2019

Codecov Report

Merging #10725 into master will increase coverage by 0.0111%.
The diff coverage is 66.6666%.

@@               Coverage Diff                @@
##             master     #10725        +/-   ##
================================================
+ Coverage   79.6565%   79.6676%   +0.0111%     
================================================
  Files           414        414                
  Lines         87817      87865        +48     
================================================
+ Hits          69952      70000        +48     
+ Misses        12682      12680         -2     
- Partials       5183       5185         +2

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alivxxx alivxxx added the status/LGT1 Indicates that a PR has LGTM 1. label Jun 5, 2019
Copy link
Contributor

@XuHuaiyu XuHuaiyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@XuHuaiyu XuHuaiyu merged commit 54e4894 into pingcap:master Jun 5, 2019
@alivxxx alivxxx deleted the bind-lease branch June 5, 2019 09:32
@alivxxx alivxxx added status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jun 5, 2019
alivxxx added a commit to alivxxx/tidb that referenced this pull request Jun 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT2 Indicates that a PR has LGTM 2. type/enhancement The issue or PR belongs to an enhancement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add a config item for the duration to update the sql bind table
3 participants