types: fix incorrect weekday for ALLOW_INVALID_DATES mode
#10864
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #10864 +/- ##
===========================================
Coverage 81.2957% 81.2957%
===========================================
Files 423 423
Lines 90124 90124
===========================================
Hits 73267 73267
Misses 11557 11557
Partials 5300 5300 |
imtbkcat
added
contribution
imtbkcat
reviewed
Jul 8, 2019
| if err != nil { | ||
| return 0 | ||
| return t1.Weekday() |
There was a problem hiding this comment.
Suggested change
| return t1.Weekday() | |
| t1, _ := t.GoTime(gotime.Local) | |
| return t1.Weekday() |
I think this is better.
There was a problem hiding this comment.
we can't ignore err check
imtbkcat
changed the title
weekdayweekday for ALLOW_INVALID_DATES mode
|
/run-all-tests |
|
@b41sh We may need to cherry pick this one to release branches including release-3.1. |
|
It seems that, not for sure, we failed to cherry-pick this commit to release-2.1 release-3.0. Please comment '/run-cherry-picker' to try to trigger the cherry-picker if we did fail to cherry-pick this commit before. @imtbkcat PTAL. |
|
/run-cherry-picker |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
Signed-off-by: sre-bot <sre-bot@pingcap.com>
|
cherry pick to release-2.1 in PR #16169 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
|
cherry pick to release-3.0 in PR #16170 |
sre-bot
pushed a commit
to sre-bot/tidb
that referenced
this pull request
Apr 8, 2020
|
cherry pick to release-3.1 in PR #16171 |
sre-bot
added a commit
that referenced
this pull request
Apr 8, 2020
sre-bot
added a commit
that referenced
this pull request
Apr 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Fix the problem invalid
weekdayfunction#10835
What is changed and how it works?
ignore GoTime error
Check List
Tests