executor: fix point get snapshot TS for pessimistic transaction. #11012
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/run-all-tests |
Codecov Report
@@ Coverage Diff @@
## master #11012 +/- ##
===============================================
- Coverage 81.0171% 80.952% -0.0652%
===============================================
Files 418 418
Lines 89428 89264 -164
===============================================
- Hits 72452 72261 -191
- Misses 11739 11764 +25
- Partials 5237 5239 +2 |
|
LGTM |
coocood
added
status/LGT1
jackysp
approved these changes
Jul 1, 2019
tiancaiamao
approved these changes
Jul 1, 2019
coocood
added a commit
to coocood/tidb
that referenced
this pull request
Jul 1, 2019
coocood
added a commit
that referenced
this pull request
Jul 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Select for update use PointGet executor, the TS for the snapshot always use startTS, result in wrong result.
What is changed and how it works?
Set the snapshot TS to forUpdateTS if the point get locks the key.
Check List
Tests
Related changes