Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

planner: fix union scan on partition table bug #11187

Merged
merged 2 commits into from
Jul 11, 2019

Conversation

crazycs520
Copy link
Contributor

What problem does this PR solve?

fix union scan on partition table bug

create table t (a int) partition by hash(a) partitions 4;
begin
insert into t values (0),(1);
select * from t where a>0; 
+---+
| a |
+---+
| 1 |
| 0 | --bug: filter is a>0
+---+

What is changed and how it works?

Check List

Tests

  • Unit test

Code changes

  • Has exported function/method change

Side effects

Related changes

  • Need to cherry-pick to the release branch

@crazycs520 crazycs520 added type/bugfix This PR fixes a bug. priority/release-blocker This issue blocks a release. Please solve it ASAP. labels Jul 11, 2019
@crazycs520
Copy link
Contributor Author

/run-all-tests

@crazycs520
Copy link
Contributor Author

@tiancaiamao @zz-jason PTAL

@codecov
Copy link

codecov bot commented Jul 11, 2019

Codecov Report

Merging #11187 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11187   +/-   ##
===========================================
  Coverage   82.1848%   82.1848%           
===========================================
  Files           423        423           
  Lines         94678      94678           
===========================================
  Hits          77811      77811           
  Misses        11553      11553           
  Partials       5314       5314

@eurekaka eurekaka mentioned this pull request Jul 11, 2019
Copy link
Contributor

@eurekaka eurekaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@alivxxx alivxxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@eurekaka eurekaka added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 11, 2019
@alivxxx alivxxx added status/all tests passed status/LGT2 Indicates that a PR has LGTM 2. and removed status/LGT1 Indicates that a PR has LGTM 1. labels Jul 11, 2019
@alivxxx alivxxx merged commit b43668d into pingcap:master Jul 11, 2019
crazycs520 added a commit to crazycs520/tidb that referenced this pull request Jul 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority/release-blocker This issue blocks a release. Please solve it ASAP. status/LGT2 Indicates that a PR has LGTM 2. type/bugfix This PR fixes a bug.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants