expression: function INSERT should return NULL if any argument is NULL #11237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #11237 +/- ##
===========================================
Coverage 81.4776% 81.4776%
===========================================
Files 423 423
Lines 90793 90793
===========================================
Hits 73976 73976
Misses 11512 11512
Partials 5305 5305 |
|
/run-all-tests |
tcmichael
changed the title
tcmichael
changed the title
|
@SunRunAway PTAL |
|
/run-all-tests |
SunRunAway
added
component/expression
contribution
wshwsh12
added
status/LGT2
eurekaka
changed the title
|
/run-all-tests |
|
@tcmichael Thanks for the contribution, it would be appreciated if you can help to cherry-pick this fix to release-2.1 and release-3.0 branch as well. |
SunRunAway
added a commit
to SunRunAway/tidb
that referenced
this pull request
Jul 15, 2019
wshwsh12
added a commit
to SunRunAway/tidb
that referenced
this pull request
Jul 15, 2019
wshwsh12
added a commit
to SunRunAway/tidb
that referenced
this pull request
Jul 15, 2019
This was referenced Jul 15, 2019
zz-jason
added a commit
to SunRunAway/tidb
that referenced
this pull request
Jul 15, 2019
zz-jason
added a commit
to SunRunAway/tidb
that referenced
this pull request
Jul 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Function INSERT should be NULL if any argument is NULL.
Closes#11174
What is changed and how it works?
change order of error judgement.
Check List
Tests