Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ddl: refine error messages in unsupported column options (#11065) #11274

Merged
merged 2 commits into from
Jul 19, 2019

Conversation

tangenta
Copy link
Contributor

Cherry-pick #11065.

@tangenta
Copy link
Contributor Author

/run-all-tests

@tangenta
Copy link
Contributor Author

@crazycs520 @zimulala @bb7133 PTAL

Copy link
Member

@zz-jason zz-jason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better to also cherry-pick the test code.

@tangenta
Copy link
Contributor Author

My mistake. PTAL @zz-jason

@zz-jason
Copy link
Member

LGTM

@zz-jason zz-jason added the status/LGT1 Indicates that a PR has LGTM 1. label Jul 19, 2019
Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zz-jason zz-jason merged commit ffe55b8 into pingcap:release-3.0 Jul 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status/LGT1 Indicates that a PR has LGTM 1.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants