Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ddl: refine error messages in unsupported column options #11065 #11331

Merged
merged 1 commit into from
Jul 22, 2019
Merged

ddl: refine error messages in unsupported column options #11065 #11331

merged 1 commit into from
Jul 22, 2019

Conversation

tangenta
Copy link
Contributor

@tangenta tangenta commented Jul 19, 2019 •
edited by bb7133
Loading

Cherry-pick #11065, this PR closes #11303

winkyao
winkyao reviewed Jul 19, 2019
View reviewed changes
Copy link
Contributor

@winkyao winkyao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tangenta
Copy link
Contributor Author

@bb7133 PTAL

bb7133
bb7133 approved these changes Jul 19, 2019
View reviewed changes
Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@winkyao
Copy link
Contributor

winkyao commented Jul 19, 2019

/run-all-tests

@tangenta
Copy link
Contributor Author 

[2019-07-19T06:43:10.415Z] ----------------------------------------------------------------------
[2019-07-19T06:43:10.415Z] FAIL: conn_test.go:172: ConnTestSuite.TestConnExecutionTimeout
[2019-07-19T06:43:10.415Z] 
[2019-07-19T06:43:10.415Z] conn_test.go:228:
[2019-07-19T06:43:10.415Z]     c.Assert(err, IsNil)
[2019-07-19T06:43:10.415Z] ... value *errors.withStack = [executor:1317]Query execution was interrupted ("[executor:1317]Query execution was interrupted")

@zimulala zimulala added the status/LGT2 Indicates that a PR has LGTM 2. label Jul 19, 2019
@tangenta
Copy link
Contributor Author

/run-unit-test

@tangenta
Copy link
Contributor Author

All tests passed. Merge this PR please. @winkyao

@winkyao winkyao merged commit 7db2a1d into pingcap:release-2.1 Jul 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@winkyao winkyao winkyao left review comments

@bb7133 bb7133 bb7133 approved these changes

Assignees
No one assigned
Labels
status/LGT2 Indicates that a PR has LGTM 2.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tangenta @winkyao @bb7133 @zimulala