fix ConvertJSONToInt unsigned bug #11483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
H-ZeX
added
needs-cherry-pick-2.1
type/bugfix
|
/test |
|
/run-all-tests |
crazycs520
reviewed
Jul 29, 2019
expression/integration_test.go
Outdated
| @@ -2180,6 +2180,7 @@ func (s *testIntegrationSuite) TestBuiltin(c *C) { | |||
| result.Check(testkit.Rows("2017-01-01 00:00:00.00")) | |||
| result = tk.MustQuery(`select cast(20170118.999 as datetime);`) | |||
| result.Check(testkit.Rows("2017-01-18 00:00:00")) | |||
| tk.MustExec(`select convert(a2.a, unsigned int) from (select cast('"9223372036854775808"' as json) as a) as a2;`) | |||
There was a problem hiding this comment.
s/MustExec/MustQuery/
Otherwise, you will find you can pass this test in master too.
There was a problem hiding this comment.
s/MustExec/MustQuery/
Otherwise, you will find you can pass this test in master too.
What's difference between this two MustXXX operations?
Codecov Report
@@ Coverage Diff @@
## master #11483 +/- ##
===========================================
Coverage 81.3173% 81.3173%
===========================================
Files 425 425
Lines 91668 91668
===========================================
Hits 74542 74542
Misses 11771 11771
Partials 5355 5355 |
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
…o fix-StrToInt-unsigned-bug
AilinKid
added
status/LGT2
winkyao
added
the
status/can-merge
|
/run-all-tests |
ngaut
approved these changes
Jul 31, 2019
|
cherry pick to release-2.1 failed |
|
cherry pick to release-3.0 in PR #11551 |
sre-bot
added a commit
that referenced
this pull request
Aug 5, 2019
H-ZeX
added a commit
to H-ZeX/tidb
that referenced
this pull request
Oct 30, 2019
Signed-off-by: H-ZeX <hzx20112012@gmail.com>
sre-bot
pushed a commit
that referenced
this pull request
Oct 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: H-ZeX hzx20112012@gmail.com
What problem does this PR solve?
The origin
ConvertJSONToIntwill fail in this sqlselect convert(a2.a, unsigned int) from (select cast('"9223372036854775808"' as json) as a) as a2;What is changed and how it works?
call
StrToIntorStrToUintaccording to the paramunsigned.Check List
Tests
Code changes
No
Side effects
No.
Related changes
No.