Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sessionctx/variable: change add index variable default value #11786

Merged
merged 3 commits into from
Aug 23, 2019

Conversation

crazycs520
Copy link
Contributor

@crazycs520 crazycs520 commented Aug 20, 2019

What problem does this PR solve?

In order to reduce the impact of User service, After testing of add index with sysbench by @bb7133 , we decide to adjust the add index variable default value.

What is changed and how it works?

Check List

Tests

  • No code

Code changes

Side effects

Related changes

  • Need to cherry-pick to the release branch

Release note

  • Modify some default parameters related to DDL add index, in order to reduce the impact on the online workloads

@crazycs520
Copy link
Contributor Author

/run-all-tests

@codecov
Copy link

codecov bot commented Aug 20, 2019

Codecov Report

Merging #11786 into master will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             master     #11786   +/-   ##
===========================================
  Coverage   81.5957%   81.5957%           
===========================================
  Files           435        435           
  Lines         94766      94766           
===========================================
  Hits          77325      77325           
  Misses        11957      11957           
  Partials       5484       5484

Copy link
Contributor

@zimulala zimulala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@bb7133
Copy link
Member

bb7133 commented Aug 23, 2019

Please add the "Release Notes", thanks!

@crazycs520
Copy link
Contributor Author

/run-all-tests

Copy link
Member

@bb7133 bb7133 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor Author

/run-all-tests

Copy link
Contributor

@tangenta tangenta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crazycs520
Copy link
Contributor Author

/run-all-tests

@you06 you06 added the sig/sql-infra SIG: SQL Infra label Mar 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sig/sql-infra SIG: SQL Infra
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants