executor: add several sql hint related to session variables #11809
Conversation
Codecov Report
@@ Coverage Diff @@
## master #11809 +/- ##
===========================================
Coverage 81.6107% 81.6107%
===========================================
Files 455 455
Lines 101380 101380
===========================================
Hits 82737 82737
Misses 12852 12852
Partials 5791 5791 |
|
PTAL. @qw4990 @lzmhhh123 |
foreyes
force-pushed
the
dev/add_sql_hints
branch
from
390a337
to
3431942
Compare
|
PTAL. @qw4990 |
|
Almost LGTM, and please address comments and resolve CI problems @foreyes . |
|
/run-all-tests |
|
Address comments and add some tests. PTAL again. @qw4990 |
foreyes
added
status/all tests passed
status/LGT1
foreyes
requested review from
lzmhhh123 and
XuHuaiyu
and removed request for
lzmhhh123
|
PTAL. @XuHuaiyu |
|
/run-unit-test |
| c.Assert(tk.Se.GetSessionVars().StmtCtx.MemTracker.CheckBytesLimit(val), IsTrue) | ||
| tk.MustExec("select /*+ MEMORY_QUOTA(1 GB), MEMORY_QUOTA(1 MB) */ 1;") | ||
| val = int64(1) * 1024 * 1024 | ||
| c.Assert(tk.Se.GetSessionVars().StmtCtx.GetWarnings(), HasLen, 1) |
There was a problem hiding this comment.
May we check the warning msg?
There was a problem hiding this comment.
Warning messages need to be dealt with specially later, and there is no need to care too much about them at this stage.
| c.Assert(tk.Se.GetSessionVars().GetReplicaRead(), Equals, kv.ReplicaReadLeader) | ||
| } | ||
|
|
||
| func (s *testSessionSuite) TestStmtHints(c *C) { |
There was a problem hiding this comment.
Should we add some test case with hints in subqueries?
There was a problem hiding this comment.
It's unlikely to support use these hints in subqueries.
These hints need to handle before sql execute and set statement variables, handle them in subquries is too expensive.
Maybe discuss with PM team later.
|
address comment, add test and change a few codes. |
XuHuaiyu
added
status/can-merge
|
/run-all-tests |
What problem does this PR solve?
Add SQL hints:
MEMORY_QUOTA,USE_TOJA,NO_INDEX_MERGE,READ_CONSISTENT_REPLICAWhat is changed and how it works?
Extract sql hints before executing each query, and store hints in
StmtCtx.When we need access or set related session variables, we have to use interfaces instead.
For example, if there is ReplicaRead hint in StmtCtx,
GetReplicaRead()will return the value in StmtCtx, otherwise returnSessionVars.replicaRead.Check List
Tests
Code Changes
Release Notes
Support several SQL hints related to session variables: MEMORY_QUOTA, USE_TOJA, NO_INDEX_MERGE, READ_CONSISTENT_REPLICA.